? ? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
29 Dec 2017

Summary of Changes

Some styling updates for com_search
This PR also addresses some of the form UI updates introduced into BS4-beta.3

avatar C-Lodder C-Lodder - open - 29 Dec 2017
avatar C-Lodder C-Lodder - change - 29 Dec 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Dec 2017
Category Front End com_search Libraries Modules Templates (site)
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Dec 2017

@C-Lodder can you please describe what styling changes are tester have to look for or is this a Code review?

avatar C-Lodder
C-Lodder - comment - 30 Dec 2017

Just ensuring the forum ties in with Bootstrap as opposed to unstyled elements. Can be a code review

avatar wilsonge
wilsonge - comment - 30 Dec 2017

We need to fix travis tests here before it gets merged too

avatar C-Lodder C-Lodder - change - 30 Dec 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 Dec 2017
Category Front End com_search Libraries Modules Templates (site) Front End com_search Libraries Modules Templates (site) Unit Tests
avatar C-Lodder C-Lodder - change - 30 Dec 2017
Labels Added: ?
avatar C-Lodder
C-Lodder - comment - 31 Dec 2017

@wilsonge done

avatar joomla-cms-bot joomla-cms-bot - change - 2 Jan 2018
Category Front End com_search Libraries Modules Templates (site) Unit Tests JavaScript Repository Front End com_search Libraries Modules Templates (site) Unit Tests
avatar C-Lodder
C-Lodder - comment - 2 Jan 2018

@wilsonge conflicts done. Once merged I'll fix the other PR's

avatar joomla-cms-bot joomla-cms-bot - change - 2 Jan 2018
Category Front End com_search Libraries Modules Templates (site) Unit Tests JavaScript Repository Front End com_search Libraries Modules Templates (site) Unit Tests
avatar wilsonge
wilsonge - comment - 2 Jan 2018

com_search seems to be broken before and after this patch (it misses the option=com_search from the URL) but after manually adding that into the url, things work, and styling does look better after applying this patch. So merging this and going to create an issue to figure out why search isn't working

avatar wilsonge wilsonge - change - 2 Jan 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-01-02 23:16:11
Closed_By wilsonge
avatar wilsonge wilsonge - close - 2 Jan 2018
avatar wilsonge wilsonge - merge - 2 Jan 2018

Add a Comment

Login with GitHub to post a comment