?
avatar infograf768
infograf768
20 Dec 2017

Normally, any third party extension working fine in 3.9 should be OK in 4.0.
I found out that this was not the case for the radio field class.
Other stuff may also be at stake. Did not test all.

a 3.8 or 3.9 extension may use the class class="btn-group btn-group-yesno" for a radio field as this is the norm there.

Unhappily, such a class will just break the field in 4.0, i.e. we can't switch.
For it to work, we have to change the class to class="switcher"

@C-Lodder

avatar infograf768 infograf768 - open - 20 Dec 2017
avatar joomla-cms-bot joomla-cms-bot - change - 20 Dec 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 20 Dec 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Dec 2017
Category Code style
avatar brianteeman
brianteeman - comment - 21 Dec 2017

Isnt that the expected behaviour - I didnt think the comment about extensions working applied to the css

avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Dec 2017
Status New Discussion
avatar C-Lodder
C-Lodder - comment - 21 Dec 2017

Am I right in asusming the btn-group btn-group-yesno class changed the button sizes and ensured one was red and the other was green?

avatar brianteeman
brianteeman - comment - 21 Dec 2017

as far as i can tell then yes

avatar C-Lodder
C-Lodder - comment - 21 Dec 2017

@infograf768 The btn-group class it still supported. I don't know about btn-group-yesno though as I can't remember that far back. If it doesn't work, then I can add it back in.

avatar brianteeman
brianteeman - comment - 23 Dec 2017

I just tested an instance of class="btn-group btn-group-yesno" that is still present in J4 - it looks ugly but it does still work

in com_modules options the adminlangfilter radio in the options

avatar brianteeman
brianteeman - comment - 23 Dec 2017

sorry - double checking it i can see that it only kind of works sometimes

avatar brianteeman
brianteeman - comment - 29 Dec 2017

closed as we have a PR for testing see #19213

avatar brianteeman brianteeman - change - 29 Dec 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-12-29 16:40:08
Closed_By brianteeman
avatar brianteeman brianteeman - close - 29 Dec 2017
avatar C-Lodder
C-Lodder - comment - 29 Dec 2017

This PR only addresses the default styling. It doesn't fix the btn-group-yes-no-maybe-definitely-supposedly (whatever it is) class

Add a Comment

Login with GitHub to post a comment