Feeling Lucky
?
[#19109] - Improve UsersHelperRoute
- Fixed in Code Base
- 21 Dec 2017
- Medium
- Build: staging
- # 19109
- Diff
- joomdonation:patch-5
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR makes small improvements to UsersHelperRoute code (maybe it is just my preferred code style):
-
Remove unnecessary variables use (call methods chain directly)
-
Return early when a menu item found and null when nothing found (no need to use $itemid variable for storing data)
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_users |
Quy
- comment
- 20 Dec 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19109.
Quy
- comment
- 20 Dec 2017
Ready to Commit after two successful tests.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 20 Dec 2017
Ready to Commit after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-21 00:08:38 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 100b448
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19109.