? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
20 Dec 2017

Pull Request for Issue # .

Summary of Changes

This PR fixes wrong link to user profile when there is a menu item created to link to user profile menu option. When we call JRoute::_('index.php?option=com_users&view=profile') to get link to user profile, instead of getting /joomla/index.php/user-profile, we actual get /joomla/index.php/user-profile/profile (profile at the end is name of the view, it is not needed)

Testing Instructions

  1. Create a menu item to link to user profile menu option of com_users, set alias to user-profile (you don't have to do that if you install Joomla with testing sample data)

  2. Open the file templates/protostar/index.php, add the below command:

echo JRoute::_('index.php?option=com_users&view=profile');
  1. Before patch, you will see URL like this /joomla/index.php/user-profile/profile (note profile at the end, it is not needed)

  2. After patch, correct URL is displayed /joomla/index.php/user-profile (it is the URL of menu item you create to link to user profile)

Expected result

URL without profile at the end when a menu item to link to user profile menu option is available

Actual result

URL still has profile at the end.

Ping @csthomas to have a look as you have experience with Joomla routing

avatar joomdonation joomdonation - open - 20 Dec 2017
avatar joomdonation joomdonation - change - 20 Dec 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Dec 2017
Category ⇒ Front End com_users
avatar joomdonation joomdonation - change - 20 Dec 2017
The description was changed
avatar joomdonation joomdonation - edited - 20 Dec 2017
avatar tonypartridge
tonypartridge - comment - 20 Dec 2017

Does the previous link still work with this PR too? or at least 301 redirect to the new link?

avatar csthomas
csthomas - comment - 20 Dec 2017

This PR changes only the building process. Both links still work.

avatar tonypartridge
tonypartridge - comment - 20 Dec 2017

Cool, I didn’t have chance to check the code just thought it was worth mentioning whilst browsing on my phone.

On 20 Dec 2017, 23:20 +0000, Tomasz Narloch notifications@github.com, wrote:

This PR changes only the building process. Both links still work.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar joomdonation joomdonation - change - 3 Oct 2018
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-10-03 01:30:46
Closed_By ⇒ joomdonation
Labels Added: ?
avatar joomdonation joomdonation - close - 3 Oct 2018

Add a Comment

Login with GitHub to post a comment