[#19108] - Improve UsersRouterRulesLegacy build method
- Fixed in Code Base
- 23 Dec 2017
- Medium
- Build: staging
- # 19108
- Diff
- joomdonation:patch-3
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR makes small improvement to UsersRouterRulesLegacy build to make code shorter (and easier to read). Also, when a menu item match a view, we move to check the next menu item (continue command), so performance will be increased a bit, too
Testing Instructions
-
Code review
-
Apply patch, check and make sure links to registration form, forgot username, forgot password still works like before
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_users |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19108.
This can be made shorter by making them elseif and removing the continue statements except for the first one.
That would work, too. But I am not sure if it will make the code a bit more difficult to follow (too many elseif)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19108.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-23 15:59:56 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Tested and Works.
System information
3.8.4-dev
Multilanguage Site (4 Lang.) & Test English (GB) Sample Data
macOS Sierra, 10.12.6
Firefox 57 (64-bit)
MAMP 4.2