? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
16 Dec 2017

Summary of Changes

  1. Login page now based on flexbox
  2. Remove inline CSS
  3. Move JS to separate file
  4. Fix styling for language dropdown
avatar C-Lodder C-Lodder - open - 16 Dec 2017
avatar C-Lodder C-Lodder - change - 16 Dec 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Dec 2017
Category Modules Administration Templates (admin) JavaScript
avatar dgt41
dgt41 - comment - 16 Dec 2017

@C-Lodder you still need to wrap the code with:

document.addEventListener(`DOMContentLoaded`, function() {
yourCodeHere
});

untill we manage to append those scripts at the bottom of the page instead of the head

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 16 Dec 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Dec 2017

I have tested this item successfully on 5f05a3d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19087.

avatar C-Lodder
C-Lodder - comment - 16 Dec 2017
avatar dgt41
dgt41 - comment - 16 Dec 2017

@C-Lodder one beer from me to whomever did that ?

avatar Anu1601CS
Anu1601CS - comment - 17 Dec 2017

Are bottom links are removed from mobile view??
screen shot 2017-12-17 at 07 52 15


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19087.

avatar C-Lodder
C-Lodder - comment - 17 Dec 2017

@Anu1601CS correct

avatar Anu1601CS Anu1601CS - test_item - 17 Dec 2017 - Tested successfully
avatar Anu1601CS
Anu1601CS - comment - 17 Dec 2017

I have tested this item successfully on 5f05a3d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19087.

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Dec 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Dec 2017

Ready to Commit after two successful tests.

avatar wilsonge wilsonge - change - 20 Dec 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-12-20 00:13:10
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 20 Dec 2017
avatar wilsonge wilsonge - merge - 20 Dec 2017

Add a Comment

Login with GitHub to post a comment