?
avatar C-Lodder
C-Lodder
16 Dec 2017

In BS4-beta, the hidden-*-* classes were removed in favour of d-*-*.

This needs to be applied over the entire CMS

avatar C-Lodder C-Lodder - open - 16 Dec 2017
avatar joomla-cms-bot joomla-cms-bot - change - 16 Dec 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 16 Dec 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Dec 2017
Category Code style
avatar dgt41
dgt41 - comment - 16 Dec 2017

Because d means hidden... in another parallel universe

avatar C-Lodder
C-Lodder - comment - 16 Dec 2017

Yeah it's stupid, but d === display

avatar dgt41
dgt41 - comment - 16 Dec 2017

If d stands for display then hidden === d make no freaking sense, but that’s ok because bootstrap doesn’t make any sense anymore ?

avatar C-Lodder
C-Lodder - comment - 16 Dec 2017

Well it does make sense cause before you had to use hidden- or visible-, and now it's just d-, so the approach is better. It also couples nicely with the flex utilities

The fact it's d- instead of display- is odd but meh.

avatar dgt41
dgt41 - comment - 16 Dec 2017

Well for a BEM fan bootscrap will never make any sense. Anyways this needs to be done

avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Dec 2017
Status New Discussion
avatar brianteeman
brianteeman - comment - 20 Dec 2017

d stands for display utilities and when you look at the totality of what the new display utility classes do then it makes sense https://getbootstrap.com/docs/4.0/utilities/display/

avatar infograf768
infograf768 - comment - 20 Dec 2017

Would not this be not B/C?
I tested some 3.8. components using radio fields and I found out that all such fields needed the class to be changed to

type="radio"
class="switcher"

because otherwise, they just would not work at all.

I understand many aspects will not be B/C in 4.0, but have'nt we been told that an extension working fine in 3.9 will be OK for 4.0 ?

This is a genuine question, not a rant.

avatar C-Lodder
C-Lodder - comment - 20 Dec 2017

@infograf768 - I'm referring to hidden-*-*, not hidden-*

The later was deprecated in BS 2.3 if I rightly remember. BS4 moved to the new display utilities in beta-1 and seeing as J4 is in alpha, it's fine.

Side note, this has nothing to do with the switcher. The switcher class is optional on fields, not required

avatar infograf768
infograf768 - comment - 20 Dec 2017

Side note, this has nothing to do with the switcher. The switcher class is optional on fields, not required

I understand this has nothing to do with the switcher. But when you have though a class class="btn-group btn-group-yesno" in 3.9, it will not work in 4.0.

avatar C-Lodder
C-Lodder - comment - 20 Dec 2017

Please open a new issue.

You may have a valid point, but I do not want to have to look through unrelated issues in the future, for the topic I need to search for

avatar infograf768
infograf768 - comment - 20 Dec 2017

Sure.

avatar infograf768
infograf768 - comment - 20 Dec 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Dec 2017
Build staging 4.0-dev
avatar ciar4n
ciar4n - comment - 8 Jan 2018

PR created #19332

avatar franz-wohlkoenig franz-wohlkoenig - change - 8 Jan 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-01-08 13:08:12
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jan 2018
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 8 Jan 2018
avatar joomla-cms-bot
joomla-cms-bot - comment - 8 Jan 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Jan 2018

closed as having Pull Request #19332

Add a Comment

Login with GitHub to post a comment