[#18982] - In-menu-item modal modual editor fix
- Fixed in Code Base
- 21 Dec 2017
- Medium
- Build: staging
- # 18982
- Diff
- okonomiyaki3000:fix-insane-modal-js
- Success hound No violations found. Woof! Details
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #18979 .
Summary of Changes
Instead of one modal per module -> one generalized modal for ALL modules
Instead of specific js functions for each modal -> generalized js for ALL modals
Testing Instructions
- Have a lot of modules
- Edit a menu item
Expected result
Only one modal should be created and reused for all module editors.
Minimal, generalized js should be written to handle all modals.
More modules should not mean more js/html code.
Actual result
Before this patch, it's possible to get out of memory error if you have enough modules.
After, should not be possible.
Documentation Changes Required
Nope
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
The key point would be PHP's memory setting. If it's very high, you might be fine but you shouldn't need to give PHP tons of memory to edit a menu item.
Can you give a Memory Limit to test proper?
I had less than 200 modules and a memory limit of 128MB and it was crashing. So try it with 32MB and you can probably crash it with 50 or so modules. Go down to 16 if you really want to be sure.
@okonomiyaki3000 thanks for Info, will test. Can you update Test Instructions with above Limits so willing Testers have not to search for proper Information?
Didn't get a Crash without PR:
- 200 Modules
- memory_limit 16M
System information
3.8.3-rc
Multilanguage Site (4 Lang.) & Sample Data
macOS Sierra, 10.12.6
Firefox 57 (64-bit)
MAMP 4.2
- PHP 7.0.22
- MySQLi 5.6.35
it is not the memory limit
the problem is almost certainly max_input_vars
This has been reported before (and closed) and PR submitted, rejected or abandoned
If you check the server logs you should see the error report there which explains it
The crash happens when opening a menu item, not saving. What can input variables have to do with it? Raising my memory limit to 256MB allowed me to open the page at which point I could see the crazy loads of javascript and modals being written.
I have tested this item
I have joomla staging with sample testing data installed.
Before patch page has ~240 KB
After ~100 KB
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18982.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18982.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
For those of you not experiencing a crash, were you running in debug mode or not? I suppose that may make a difference.
@okonomiyaki3000 no Debug-Mode running at Test.
@franz-wohlkoenig Debug mode will make it more likely that you'll experience an out-of-memory crash because it adds quite a bit of memory overhead. It could be that this crash is not likely to happen at all unless you are using debug mode.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-21 00:11:09 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Using 250 Modules and edit a Menu-Item Site should crash on this Setting:
System information
3.8.3-rc
Multilanguage Site (4 Lang.) & Sample Data
macOS Sierra, 10.12.6
Firefox 57 (64-bit)
MAMP 4.2