[#18981] - Remove NONE value from category blog multiple tags filter
- Fixed in Code Base
- 5 Dec 2017
- Medium
- Build: staging
- # 18981
- Diff
- Quy:patch-11
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #18785.
Summary of Changes
With PR #18234, it is possible to select multiple tags. Therefore, it is no longer necessary to default to NONE value when no tags selected.
Testing Instructions
- Create a Joomla article category blog menu
- Leave Tags field empty.
- Save
Expected result
Editing a category menu should not alter its URL structure
Actual result
Editing a category menu alters the URL structure (appends filter_tag[0]=) when no tags selected.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18981.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18981.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
Personally I like that it displays "NONE" and there is no code consequences of it being there.
What is the benefit of removing it?
Well, now it appends "?filter_tag[0]" to the category blog URL which is wrong/bad looking.
And either way, it's not really that useful to display "NONE". If there is no tag inserted, it's obvious that it's none.
This is a normal multiple-select field and we never display a NONE for when nothing is selected in a multiple-select.
ok that makes sense then
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-05 15:00:28 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on ebbf282
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18981.