[#18983] - Fix fatal error in getCategoryId method in several router classes
- Fixed in Code Base
- 6 Dec 2017
- Medium
- Build: staging
- # 18983
- Diff
- joomdonation:routing_fix_getcategoryid
- Pending continuous-integration/drone/pr this build is pending Details
- Success hound No violations found. Woof! Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #18927.
Summary of Changes
This PR fixes "Call to a member function getChildren() on null" Error for modern routing when Joomla parses a SEF URL which is linked to a category which user doesn't have access to. See #18927 for issue description
Technical, this PR does two things:
-
Add 'access' => false to JCategories::getInstance method calls so that access level is not checked when getting category
-
Add a check to make sure a valid category is returned before calling later code (avoid fatal error)
Testing Instructions
-
Confirm the issue described at #18927
-
Apply patch, confirm the issue is fixed
Ping @justinherrin for testing since he reported the issue.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact com_content com_newsfeeds |
I have tested this item
I was able to test this patch successfully! I tried the following URLs, and all successfully redirected me to login page, and then back to the original URL once I was logged in :)
domain.com/test-category-menu-item-alias/test-article-alias
domain.com/test-category-menu-item-alias/test-sub-category-alias
domain.com/test-category-menu-item-alias/test-sub-category-alias/test-sub-category-article-alias
I was also tried each URL with the parameter to keep IDs in URLs in those worked too.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18983.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18983.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18983.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-06 14:43:01 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Drone is showing a strange error http://ci.joomla.org/joomla/joomla-cms/1468. Maybe it needs to be re-started?