[#18912] - [4.0][WIP] More external scripts handled correctly
- Closed
- 21 May 2018
- Medium
- Build: 4.0-dev
- # 18912
- Diff
- dgrammatiko:more_ext_scripts
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
For the Joomla update process there are 2 external libraries that are required, one for json parsing and another for encryption (AES).
For Json parsing we are switching from json2 to json3 (It is a drop-in replacement for JSON 2: https://bestiejs.github.io/json3/) because Douglas Crockford turned down our request for publishing json2 to NPM (douglascrockford/JSON-js#92)!
For AES we just bumped the version to the latest available.
And that is the part that takes care of the maintenance of the external scripts, but there is an ongoing work to drop jQuery from all the scripts. The later will be finished by the javascript team, but feel free to help with a PR.
Testing Instructions
Not ready for testing yet!
Expected result
Actual result
Documentation Changes Required
Nope. Housekeeping
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository Administration com_joomlaupdate |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-21 20:03:28 |
| Closed_By | ⇒ | dgrammatiko |
Joomla cannot use npm for the aes script. Another solution needed here