? ? Pending

User tests: Successful: Unsuccessful:

avatar Ruud68
Ruud68
29 Nov 2017

Pull Request for Issue # .

Summary of Changes

This PR normalizes the plugin modal as currently used in com_redirect. It also adds a [save] button to the modal footer.

Testing Instructions

  1. normalization:
    1.1 disable the plg_redirect
    1.2 go to component / Redirect
    1.3 in the error message click on the link: "Redirect System Plugin"
    [A]
  2. save button
    2.1 change plugin status in modal to 'enabled'
    2.2 change Collect URLs to 'disabled'
    2.3 click on [Save] button (the modal should stay open)
    2.4 click on [Close] button
    [B]

Expected result

[A] The modal should open and should be same size / form / shape / etc. as other modals (like edit article in menu single article

[B] after closing the modal, the com_redirect page should refresh and the error message must be replaced with a Notice 'The Redirect Plugin is enabled. The 'Collect URLs' option in the Redirect System Plugin is disabled. Error page URLs will not be collected by this component.'
If you did not change the Collect URLs vanlue to 'disabled' there will be no warning / notice.

Actual result

[A] modal is small (width and heigth) the other modals
[B] There is no [Save] button, just a [Close] and [Save & Close] button

Documentation Changes Required

None

avatar Ruud68 Ruud68 - open - 29 Nov 2017
avatar Ruud68 Ruud68 - change - 29 Nov 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Nov 2017
Category Administration com_plugins com_redirect
avatar Ruud68 Ruud68 - change - 30 Nov 2017
Labels Added: ?
avatar Ruud68
Ruud68 - comment - 30 Nov 2017

Thanks @C-Lodder, changes made as pointed out by you :)

avatar ladyjer ladyjer - test_item - 30 Nov 2017 - Tested successfully
avatar ladyjer
ladyjer - comment - 30 Nov 2017

I have tested this item successfully on 95a6d3b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18913.

avatar Ruud68
Ruud68 - comment - 30 Nov 2017

Thanks for testing @ladyjer :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18913.

avatar infograf768
infograf768 - comment - 1 Dec 2017

Test fine here, waiting for cs to mark it such.

avatar Ruud68
Ruud68 - comment - 1 Dec 2017

@Quy @infograf768 Fixed, not sure why my own code style checker didn't 'catch' these. Thanks for reporting and testing!

avatar infograf768 infograf768 - alter_testresult - 1 Dec 2017 - ladyjer: Tested successfully
avatar infograf768 infograf768 - test_item - 1 Dec 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 1 Dec 2017

I have tested this item successfully on cc34df8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18913.

avatar infograf768 infograf768 - change - 1 Dec 2017
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 1 Dec 2017

RTC. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18913.

avatar mbabker mbabker - change - 2 Dec 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-12-02 20:15:35
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 2 Dec 2017
avatar mbabker mbabker - merge - 2 Dec 2017

Add a Comment

Login with GitHub to post a comment