? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
20 Nov 2017

Pull Request for Issue #18728 .

Summary of Changes

I'm tired enough that I'm even trying to fix javascript. Look at me go. @dgt41 - this is going outside my JS comfort zone can you confirm this is a good fix please before i merge it.

Testing Instructions

Check javascript error in console in #18728 is gone

Expected result

No JS error

Actual result

Red js error of blood, sweat and tears

avatar wilsonge wilsonge - open - 20 Nov 2017
avatar wilsonge wilsonge - change - 20 Nov 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Nov 2017
Category Unit Tests Repository JavaScript Administration com_admin
avatar brianteeman
brianteeman - comment - 20 Nov 2017

Yes you were tired as you did this on the wrong branch :)

avatar wilsonge wilsonge - change - 20 Nov 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-20 16:46:26
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 20 Nov 2017
avatar wilsonge wilsonge - merge - 20 Nov 2017
avatar joomla-cms-bot joomla-cms-bot - change - 20 Nov 2017
Category Unit Tests Repository JavaScript Administration com_admin JavaScript

Add a Comment

Login with GitHub to post a comment