J4 Issue ?
avatar zero-24
zero-24
19 Nov 2017

Steps to reproduce the issue

try to Install 4.0 on a remote database

Expected result

Sec checks about remote databases

Actual result

No sec checks on remtote databases

Additional comments

I have tried to figure out the problem but i run into a problem i don't understand. (all vars are variables are gone after that line for unknown reason)

As It looks like some strange things happen in this line here:
https://github.com/joomla-framework/database/blob/master/src/Mysqli/MysqliDriver.php#L220

mysqlinit

Important to know is the following step by step:

avatar zero-24 zero-24 - open - 19 Nov 2017
avatar joomla-cms-bot joomla-cms-bot - change - 19 Nov 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 19 Nov 2017
avatar zero-24 zero-24 - change - 19 Nov 2017
The description was changed
avatar zero-24 zero-24 - edited - 19 Nov 2017
avatar zero-24 zero-24 - change - 19 Nov 2017
The description was changed
avatar zero-24 zero-24 - edited - 19 Nov 2017
avatar wilsonge
wilsonge - comment - 19 Nov 2017

There's no code for the interface for this. I did tell @SniperSister this at JAB - I should have put it in the JSST channel too. We need to figure out how this works now that we have a single page application rather than a multi-page app.

Leave this issue open - but this isn't a quick fix and we probably need to partly solve this with @coolcat-creations from a UX perspective

avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Nov 2017
Category com_installer
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Nov 2017
Status New Discussion
avatar wilsonge wilsonge - change - 20 Nov 2017
Labels Added: ?
avatar wilsonge wilsonge - labeled - 20 Nov 2017
avatar PhilETaylor
PhilETaylor - comment - 20 Nov 2017

This is/should be a release blocker.

avatar wilsonge
wilsonge - comment - 20 Nov 2017

Indeed. Tagged as such :)

avatar zero-24
zero-24 - comment - 22 Nov 2017

Just ti be sure also the installation language strings have been dropped ... https://github.com/joomla/joomla-cms/blob/3.8.2/installation/language/en-GB/en-GB.ini#L34-L36

avatar wilsonge
wilsonge - comment - 27 Nov 2017

They shouldn’t have been dropped

avatar dgrammatiko
dgrammatiko - comment - 27 Nov 2017

FWIW the language files need a good clean up and proper English strings for some labels

avatar zero-24
zero-24 - comment - 13 Jan 2018

@wilsonge @dgt41 any updates on the installer problem with broken databases and the security checks?

avatar Quy Quy - change - 1 Oct 2019
Labels Added: ? ?
avatar Quy Quy - labeled - 1 Oct 2019
avatar Quy Quy - change - 1 Oct 2019
Labels Added: ?
avatar Quy Quy - labeled - 1 Oct 2019
avatar schultz-it-solutions
schultz-it-solutions - comment - 15 Oct 2019

I just tried to install J4-alpha11 on my system with the database residing on another server than "localhost".
This still is possible without any warning.
I would be happy to help out with testing this, if there is a solution...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18736.
avatar wilsonge
wilsonge - comment - 16 Oct 2019

Nothing yet in progress that I'm aware of. This is going to end up being a pretty major piece of work given the single page app nature now I think probably a few days to code something up

avatar zero-24 zero-24 - change - 19 Dec 2019
Labels Removed: ? ?
avatar zero-24 zero-24 - unlabeled - 19 Dec 2019
avatar zero-24 zero-24 - unlabeled - 19 Dec 2019
avatar richard67
richard67 - comment - 20 Dec 2019

@zero-24 The first link https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/vendor/joomla/database/src/Mysqli/MysqliDriver.php#L230 you give in the "Additional comments" leads to nowhere ... maybe you can replace it with a link to thesame code in the database framework package?

avatar richard67
richard67 - comment - 20 Dec 2019

@HLeithner Thanks. Maybe @zero-24 should update the link in the description?

avatar zero-24 zero-24 - change - 20 Dec 2019
The description was changed
avatar zero-24 zero-24 - edited - 20 Dec 2019
avatar zero-24
zero-24 - comment - 20 Dec 2019

updated.

avatar richard67
richard67 - comment - 27 Dec 2019

I think I will work on it soon.

avatar richard67
richard67 - comment - 28 Dec 2019

Hmm, maybe the checks have to be added to routine "validateDbConnection" in file "SetupModel.php" and not to routine "initialise" in file "DatabaseModel.php"?

avatar richard67
richard67 - comment - 28 Dec 2019

@zero-24 I see that the commented out code is inside the if (in_array($options->db_type, ['pgsql', 'postgresql'])) block in file "DatabaseModel.php". It should be below the next closing } so it comes after that "if" block. Maybe that was the reason why it did not work? And maybe it should be moved to routine "validateDbConnection" in file "SetupModel.php", like I wrote in my previous comment?

avatar dgrammatiko
dgrammatiko - comment - 28 Dec 2019

@richard67 there's nothing in the front end to support this so without creating some html and js this won't work.
Also from a UX point of view the checks are better to kick off before start asking the user to input anything. I do understand that the current code is checking the db but maybe you could twist the logic a bit to fit in the preinstall checks. It will make a much more better UX experience than convoluting the steps and confusing users by pausing the process and asking them to do the file upload. In sort, the concept needs some rethinking

avatar richard67
richard67 - comment - 28 Dec 2019

@dgrammatiko I see no html to be created, can be all done with alerts. am working on it, and parts are already working. If the check make sense or not is on the sst to decide, they once have requiested it as far as I know, and I only wanna solve this issue here and maybe improve that a bit. If later someone says throw it away I have no problem with it.

avatar richard67
richard67 - comment - 28 Dec 2019

PR is #27360 , but it is still work in progress so please don't close this issue yet.

avatar richard67
richard67 - comment - 28 Dec 2019

PR #27360 is ready for testing. This issue can be closed. @zero-24 Please test.

avatar richard67 richard67 - close - 28 Dec 2019
avatar richard67 richard67 - change - 28 Dec 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-12-28 22:50:50
Closed_By richard67
avatar richard67
richard67 - comment - 28 Dec 2019

Closed as having PR.

avatar wilsonge wilsonge - change - 11 Jan 2020
Labels Removed: ?
avatar wilsonge wilsonge - unlabeled - 11 Jan 2020

Add a Comment

Login with GitHub to post a comment