[#18464] - [4.0] Cassiopeia Header/Banner Style
- Fixed in Code Base
- 2 Nov 2017
- Medium
- Build: 4.0-dev
- # 18464
- Diff
- ciar4n:4-cassiopeia
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Header styling for the Cassiopeia frontend template
Testing Instructions
Apply PR and check frontend, with and without banner module.
Before
After
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
| Title |
|
||||||
| Labels |
Added:
?
|
||
Can you just confirm this image is from the image repo used by Joomla and not an image from Google? If so, then all good to merge
Image is from unsplash (open)... https://unsplash.com/license
The template (IMHO) should have only positions as placeholders
@dgt41 Regarding this, currently both the menu and search module positions are behind the display toggle on smaller screens. Because of this I am not sure how feasible it is to move all markup to the override,
Let me explain what should be in the override:
<nav class="navbar navbar-expand-lg">
<div class="navbar-brand">
<a href="<?php echo $this->baseurl; ?>/">
<?php echo $logo; ?>
</a>
<?php if ($this->params->get('siteDescription')) : ?>
<div class="site-description"><?php echo htmlspecialchars($this->params->get('siteDescription')); ?></div>
<?php endif; ?>
</div>
<?php if ($this->countModules('menu') || $this->countModules('search')) : ?>
<button class="navbar-toggler navbar-toggler-right" type="button" aria-hidden="true" data-toggle="collapse" data-target="#navbar" aria-controls="navbar" aria-expanded="false" aria-label="<?php echo JText::_('TPL_CASSIOPEIA_TOGGLE'); ?>">
<span class="fa fa-bars"></span>
</button>
<div class="collapse navbar-collapse" id="navbar">
<!-- !!! Here goes the menu output-->
<?php if ($this->countModules('search')) : ?>
<div class="form-inline">
<!-- !!! Here goes the search module -->
</div>
<?php endif; ?>
</div>
<?php endif; ?>
</nav>
<?php if ($this->countModules('banner')) : ?>
<div class="container-banner">
<jdoc:include type="modules" name="banner" style="xhtml" />
</div>
<?php endif; ?>
<div class="header-shadow"></div>
<svg class="header-shape-bottom" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 736 15">
<path d="M1040,301V285s-75,12-214,12-284-26-524,0v4Z" transform="translate(-302 -285)" fill="#fff"/>
</svg>
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-02 21:28:06 |
| Closed_By | ⇒ | wilsonge |
@ciar4n nice, couple remarks here:
So all the specific implementation of the top menu (if someone wants to have a top menu? ) should go to the menu override. That will make the base template extremely versatile and flexible to any design!