? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
1 Nov 2017

When using the label element it should be explicitly associated with the form element. The for attribute of the label must exactly match the id of the form control.

A can be associated with a control either by placing the control element inside the element, or by using the for attribute.

This PR fixes the missing "for" element for the remember me label on com_login

To test go to the login component (not module) and check that the markup for the word remember me is

<label for "remember"> where remember is the id of the checkbox.

The remember me plugin must be enabled

avatar brianteeman brianteeman - open - 1 Nov 2017
avatar brianteeman brianteeman - change - 1 Nov 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Nov 2017
Category Front End com_users
avatar Quy Quy - test_item - 1 Nov 2017 - Tested successfully
avatar Quy
Quy - comment - 1 Nov 2017

I have tested this item successfully on e0eae82


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18463.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 1 Nov 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Nov 2017

I have tested this item successfully on e0eae82


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18463.

avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Nov 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Nov 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 4 Nov 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-04 14:38:04
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 4 Nov 2017
avatar mbabker mbabker - merge - 4 Nov 2017
avatar brianteeman
brianteeman - comment - 4 Nov 2017

Thanks

Add a Comment

Login with GitHub to post a comment