[#18465] - [4.0] Form field descriptions styling improvements
- Fixed in Code Base
- 3 Nov 2017
- Medium
- Build: 4.0-dev
- # 18465
- Diff
- C-Lodder:form-desc
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Let me just firstly say that this is not a concrete styling solution, so please send all disputes and complaints to UX
In J4, any form field descriptions will appear as alerts and due to the PHP file they reside in, they push the actual element.
This PR changes the description to a more simplstic helper text and move them from renderlabel.php to renderfield.php
Screenshot
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout Libraries |
| Labels |
Added:
?
|
||
It can be made accessible it does NOT need to be part of the label tag ;)
You need to have a unique id for the description and then in the field you add an aria-describedby pointing to that id.
@brianteeman I was thinking about aria-describedby as well, but we end up with quite a lot ids in each form. But kudos for the solution!
I havent touched the title attribute at all. It's still there.
I dont see a problem with having lots of ids or am i missing something
anyway there wont be a lot as there are not many descriptions ;)
I dont really care about a11y on this right now. That can be discussed by the team and be fixed properly when a decision has been made on the best approach. This is just a PR to remove those alerts
I havent touched the title attribute at all
Ok then we're golden
yeah go for it. it will be a long time before you get a response from the a11y team anyway so might as well merge it as is.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-03 11:35:16 |
| Closed_By | ⇒ | wilsonge |
Nice, but not accessible, the description needs to be part of the label tag so it will be announced on screenreaders?
Let's merge this and then ask the a11y team to take over here.
@wilsonge please merge