User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Two years ago (or so) I did this Grunt file with the aim to lift some of the day to day tasks for maintainers and also provide an easy way for contributors to compile scss files and minify js and css.
As the project (J4) moved on we added a lot more functionality and the file reached about 800 lines of code, which is kinda awkward for a task runner file.
Also we already encounter (a few times) that plugins will fall out of sync with the latest releases of the underlaying scripts (postfix, uglify, etc).
Therefore I propose a a better (for the long term) solution: plain node js code, no Grunt, no Gulp, no Webpack or Rollup. The tasks are pretty straight forward and we're not doing any packaging so webpack and rollup are totally out of the picture.
Also we are now using the package.json as the only point of truth (used to be another yaml file)
node build --compilecss
node build --installer
node build --compilejs
node build --update
Same functionality as Grunt (some command)
For documentation just run
node build --help
or just
node build
Enjoy!
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository Administration Templates (admin) Installation |
You appear to be loading the wrong jQuery UI package from NPM.
Should be this: https://www.npmjs.com/package/jquery-ui
not this: https://www.npmjs.com/package/jquery-ui-dist
Also, can we kill the uncompressed CSS files please? We're not using them at all.
Also, can we kill the uncompressed CSS files please? We're not using them at all.
Unless you're going to kill support for the core templates and core media loading uncompressed files in debug mode they should stay.
@mbabker - Atum doesn't have any uncompressed CSS files and works perfectly fine in debug mode: https://github.com/joomla/joomla-cms/tree/4.0-dev/administrator/templates/atum/css
I know it all works fine in debug mode. JHtml only uses uncompressed if it can take a .min.foo
filename, convert it to .foo
, and find a file that exists. So if uncompressed media doesn't exist then the compressed file still gets loaded.
This might be OK for the template media, but it should still be possible to get the core media in uncompressed format. Which means either we keep them in repo & ship them or people have to go through extra steps to compile them.
Labels |
Added:
?
|
@dgt41 one note:
"srcjs": "dist",
"srccss": "dist",
"filesjs": [
"cropper.js",
"cropper.min.js",
"cropper.js.map"
],
I found it confusing, because you have "srcjs": "dist",
and dist
usually contain distributive
files, not source
And question.
Is there no way to get the module path, and scan for available files, automatically?
something like :
var pathToModule = require.resolve('moduleBlabLa');
var files = scanforJsCss(pathToModule);
Could we get the conflicts on this fixed please and then merge?
Any improvements can be made at a later date
Category | JavaScript Repository Administration Templates (admin) Installation | ⇒ | JavaScript Repository Administration Templates (admin) |
Just recompile and remove the grunt-settings.yaml
Category | JavaScript Repository Administration Templates (admin) | ⇒ | JavaScript Repository Administration Templates (admin) Libraries |
Fix the conflicts and I'll merge it. I'm very uneasy about this to be honest. I still think gulp might be better for us. But let's just get it in so it's not blocking you guys
You need to fix travis please
Travis is happy again
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-17 21:20:57 |
Closed_By | ⇒ | wilsonge |
Thank you!
We are in the process pf fixing things
I forgot to mention that:
compilecss and compilejs options produce ALWAYS the same output, compared to the mess we had in grunt!