[#18445] - [fix] Frontend Filtering by author broken in modal when inserting article via xtd
- Fixed in Code Base
- 1 Nov 2017
- Medium
- Build: staging
- # 18445
- Diff
- infograf768:fe_articlextdfilter
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #18442
Summary of Changes
As the modal uses multiple, the filter_articles xml in frontend has also to use that.
Is also added here the possibility to filter by No User as in #18440
Testing Instructions
See #18442
Expected result
No more 500 or PHP Warning. Filtering works OK after patch.
After patch
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content Language & Strings |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18445.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
As the null value is -select author- shouldnt the new string be "no author"
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18445.
used the same string value as in backend when choosing ‘- No User -‘ in the modal. no need to change imho to be consequent.
I also think that whoever chose the term ‘user’ understood it is selecting a user as author. the result being a user name or none.
Means this label shows every article that has no author? When does that happen?
Means this label shows every article that has no author? When does that happen?
When you edit an article in backend you can select a user as author. The modal lets you chose No User.
@brianteeman
in fact, after a good night sleep, I think you are right. For this pr as well as the other one for backend, as we filter by author, I suggest we use « None », i.e. JNONE
I propose we let these 2 pr be merged and then make a specific pr to change the string constant.
What do you think? I also contacted @mbabker concerning this merge.
If you prefer No Author, we would just have to add this new string both in front and backend.
I just tested it, and it does not work. If i click at "No user" the article gets reasigned to Superuser. (not related to this PR) So it's not possible to show articles that have no user assigned because there is always an author.
Edit: Correction: If i create a new article and select No User it gets assigned to Super User anyway, just when i open it again and remove the user the autor is gone.
@infograf768 i agree with JNONE and a new pr for that
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-01 12:11:02 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
@infograf768 i agree with JNONE and a new pr for that
will do as well asanother improvement for the managers
@coolcat-creations
Chosing No User will only work when editing an article already saved.
I have tested this item✅ successfully on b81f778
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18445.