Feeling Lucky
?
[#18362] - Update sidebar toggle layout for aria
- Fixed in Code Base
- 24 Oct 2017
- Medium
- Build: staging
- # 18362
- Diff
- brianteeman:toggle-aria
- Pending continuous-integration/drone/pr this build is pending Details
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
This PR updates the toggle sidebar layout used in the admin eg com_content
It ensures that there is an aria-label and that the icon is hidden as per the fontawesome recommendations applied elsewhere
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration Templates (admin) Layout |
| Status | New | ⇒ | Pending |
franz-wohlkoenig
- comment
- 22 Oct 2017
@Quy can you please describe how you test?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18362.
Quy
- comment
- 24 Oct 2017
In Firefox, enable Developer Toolbar
Go to Contents > Articles
Pick an element per the Developer Toolbar
View the Inspector panel
Before PR:
After PR:
franz-wohlkoenig
- comment
- 24 Oct 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18362.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 24 Oct 2017
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-24 21:26:34 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
brianteeman
- comment
- 24 Oct 2017
Thanks
I have tested this item✅ successfully on 96b46be
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18362.