? ? ? Pending

User tests: Successful: Unsuccessful:

avatar eshiol
eshiol
18 Oct 2017

Summary of changes

Added a new filter field: Month (published)

Testing Instructions

Create a new Category List page with Filter Field = Month (published)
image

Expected result

You can filter the articles by month/year (published) in the front-end
image
in the brackets the number of articles

Actual result

System information (as much as possible)

Additional comments

Documentation Changes Required

avatar joomla-cms-bot joomla-cms-bot - change - 18 Oct 2017
Category Administration com_content Front End Language & Strings Libraries Templates (site)
avatar eshiol eshiol - open - 18 Oct 2017
avatar eshiol eshiol - change - 18 Oct 2017
Status New Pending
avatar eshiol eshiol - change - 18 Oct 2017
Title
Filter field months
[New feature] Filter field months
avatar eshiol eshiol - edited - 18 Oct 2017
avatar brianteeman
brianteeman - comment - 18 Oct 2017

In the query instead of Month created i think it should be month published
and in the string it should be clarified eg "Month (published)"

avatar eshiol eshiol - change - 18 Oct 2017
Labels Added: ? ?
avatar eshiol eshiol - change - 18 Oct 2017
The description was changed
avatar eshiol eshiol - edited - 18 Oct 2017
avatar eshiol eshiol - change - 18 Oct 2017
The description was changed
avatar eshiol eshiol - edited - 18 Oct 2017
avatar infograf768
infograf768 - comment - 19 Oct 2017

My test show that unpublished articles are counted and their published month appears in the dropdown.

Example:
screen shot 2017-10-19 at 08 30 52

screen shot 2017-10-19 at 08 34 44

I guess the query should only return articles which are published or archived.

EDIT: see below: the query is wrong as it should use a.publish_up

avatar infograf768
infograf768 - comment - 19 Oct 2017

Using published means changing the query from a.created to a.publish_up and that should solve the errors I got above.
User with correct rights will get:

screen shot 2017-10-19 at 09 10 00

avatar eshiol
eshiol - comment - 19 Oct 2017

Fixed

avatar infograf768
infograf768 - comment - 19 Oct 2017

Looks OK now here.

avatar infograf768 infograf768 - test_item - 19 Oct 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 19 Oct 2017

I have tested this item successfully on 87c704d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18361.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 19 Oct 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Oct 2017
Easy No Yes
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Oct 2017

I have tested this item successfully on 87c704d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18361.

avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Oct 2017

RTC after two successful tests.

avatar alikon
alikon - comment - 19 Oct 2017

@franz-wohlkoenig please remove RTC cause doesn't work on postgresql
screenshot from 2017-10-19 20-00-37

@eshiol
you should use something like
$query->year($db->quoteName('field'))
$query->month($db->quoteName('field'))
instead of
$query->select("concat(year(publish_up),'-',month(publish_up),'-01') as d")

avatar infograf768
infograf768 - comment - 20 Oct 2017

@alikon please test again as I can't vs postgresql

avatar alikon
alikon - comment - 20 Oct 2017

Sure i'll do

On 20 Oct 2017 11:39 am, "infograf768" notifications@github.com wrote:

@alikon https://github.com/alikon please test again as I can't vs
postgresql


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#18361 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALFsdnhx8tVZ2FkRStMBqzLbSvhcAvZks5suGpsgaJpZM4P9axL
.

avatar alikon
alikon - comment - 21 Oct 2017

still wrong SQL
screenshot from 2017-10-21 10-39-01

avatar eshiol eshiol - change - 23 Oct 2017
Labels Added: ?
avatar alikon
alikon - comment - 23 Oct 2017

no error on postgresql now
thanks @eshiol

avatar infograf768 infograf768 - test_item - 2 Nov 2017 - Not tested
avatar infograf768 infograf768 - test_item - 2 Nov 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 2 Nov 2017

I have tested this item successfully on e3a99a9

Ok too with mysql


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18361.

avatar infograf768
infograf768 - comment - 2 Nov 2017

@mbabker
can you decide of a milestone for this?

avatar franz-wohlkoenig franz-wohlkoenig - alter_testresult - 7 Dec 2017 - alikon: Tested successfully
avatar mbabker mbabker - change - 17 Mar 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-03-17 15:37:38
Closed_By mbabker
avatar mbabker mbabker - close - 17 Mar 2018
avatar mbabker mbabker - merge - 17 Mar 2018

Add a Comment

Login with GitHub to post a comment