? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
16 Oct 2017

Pull Request for Issue #18079 .

Summary of Changes

override the getLabel method
to show the label only if vote plugin is enabled

Testing Instructions

see #18079

Expected result

don't show vote/rating labels if vote plugin is disabled
screenshot from 2017-10-16 20-58-02

Actual result

screenshot from 2017-10-16 20-57-08

Documentation Changes Required

avatar joomla-cms-bot joomla-cms-bot - change - 16 Oct 2017
Category Administration com_content
avatar alikon alikon - open - 16 Oct 2017
avatar alikon alikon - change - 16 Oct 2017
Status New Pending
avatar brianteeman brianteeman - test_item - 16 Oct 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 16 Oct 2017

I have tested this item successfully on be7376e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18354.

avatar Quy Quy - test_item - 16 Oct 2017 - Tested successfully
avatar Quy
Quy - comment - 16 Oct 2017

I have tested this item successfully on be7376e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18354.

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Oct 2017

RTC after two successful tests.

avatar sandewt
sandewt - comment - 19 Oct 2017

I test this issue successfull, but ...

When I compare the 'Content - Vote' pluging p.e. with the 'Content - Page Navigation' plugin.
And disable the CPN-plugin, the Show Navigation + Switches are staying visible !!!
See Global Configuration > Articles -> Show Navigation.

So I think that the above change is not consistent. Or I'm wrong?

Note: See also my comment in issue #18079.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18354.
avatar mbabker mbabker - change - 19 Oct 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-10-19 21:54:44
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 19 Oct 2017
avatar mbabker mbabker - merge - 19 Oct 2017

Add a Comment

Login with GitHub to post a comment