Joomla! Issue Tracker | Joomla! CMS #18353 - Call router->preprocesss only once per link when sef is off

? ?

Fixed in Code Base
17 Aug 2020
Medium
Build: staging
# 18353
Diff
csthomas:issue_18289

Pending

Pending continuous-integration/drone/pr this build is pending Details
Success hound No violations found. Woof! Details
Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Success continuous-integration/appveyor/pr AppVeyor build succeeded Details

User tests: Successful: Unsuccessful:

csthomas
16 Oct 2017

Pull Request for Issue #18289

Summary of Changes

Do not call MenuRules::preprocess twice per query link if SEO settings Search Engine Friendly URLs is off.

Testing Instructions

See issue #18289

After line 63 add debug to see difference after patch:

static $i=0;$i++;$this->router->app->enqueueMessage("$i: " . print_r($query, 1));

Expected result

Method is called only once per query link.

Actual result

Method is called twice.

Documentation Changes Required

3d12c95 16 Oct 2017

Call router->preprocesss only once per link when sef is off

joomla-cms-bot - change - 16 Oct 2017

Category

⇒

Libraries

csthomas - open - 16 Oct 2017

csthomas - change - 16 Oct 2017

Status

New

⇒

Pending

csthomas - change - 16 Oct 2017

The description was changed

csthomas - edited - 16 Oct 2017

FPerisa - test_item - 9 Jan 2018 - Tested successfully

fancyFranci - comment - 9 Jan 2018

I have tested this item ✅ successfully on 3d12c95

Before:

1: Array ( [option] => com_content [view] => category [id] => 64 [Itemid] => 411 [format] => feed [type] => rss )
2: Array ( [option] => com_content [view] => category [id] => 64 [Itemid] => 411 [format] => feed [type] => rss )
3: Array ( [option] => com_content [view] => category [id] => 64 [Itemid] => 411 [format] => feed [type] => atom )
4: Array ( [option] => com_content [view] => category [id] => 64 [Itemid] => 411 [format] => feed [type] => atom )
[...]

After:

1: Array ( [option] => com_content [view] => category [id] => 64 [Itemid] => 411 [format] => feed [type] => rss )
2: Array ( [option] => com_content [view] => category [id] => 64 [Itemid] => 411 [format] => feed [type] => atom )
[...]
```<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/18353">issues.joomla.org/tracker/joomla-cms/18353</a>.</sub>

csthomas - close - 2 Sep 2018

csthomas - comment - 2 Sep 2018

Due to lack of interest, I close it.

csthomas - close - 2 Sep 2018

csthomas - change - 2 Sep 2018

Status	Pending	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2018-09-02 12:02:10
Closed_By		⇒	csthomas
Labels	Added: ?

joomdonation - comment - 2 Sep 2018

If you re-open it, I will test it on tomorrow.

csthomas - comment - 2 Sep 2018

OK, one more chance:)

csthomas - change - 2 Sep 2018

Status	Closed	⇒	New
Closed_Date	2018-09-02 12:02:10	⇒
Closed_By	csthomas	⇒

csthomas - change - 2 Sep 2018

Status

New

⇒

Pending

csthomas - reopen - 2 Sep 2018

csthomas - comment - 11 Sep 2018

Any news?

joomdonation - comment - 13 Sep 2018

@csthomas Just so you know, I looked at the PR but could not understand why it's called twice and don't know if it's safe to remove one call yet, will try to spend time to look at it later (just leave the PR opens here, even if I don't understand, I will just test it as an end-user and report the test result back)

franz-wohlkoenig - comment - 21 Jul 2019

I will just test it as an end-user and report the test result back

@joomdonation any news?

bonzani - test_item - 1 Jun 2020 - Tested successfully

bonzani - comment - 1 Jun 2020

I have tested this item ✅ successfully on 3d12c95

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18353.}

SharkyKZ - change - 1 Jun 2020

Status

Pending

⇒

Ready to Commit

SharkyKZ - comment - 1 Jun 2020

RTC.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18353.}

HLeithner - change - 17 Aug 2020

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2020-08-17 08:52:17
Closed_By		⇒	HLeithner
Labels	Added: ?

HLeithner - close - 17 Aug 2020

HLeithner - merge - 17 Aug 2020

HLeithner - comment - 17 Aug 2020

Some things take longer... thanks

wilsonge - comment - 1 Dec 2020

@csthomas I don't think this is needed in J4 with the way SiteRouter has been reworked and therefore didn't port it over with the merge conflicts. But if you disagree please can you set up a fresh pull request with info and I'll be happy to merge it with the tests from here. I'm not 100% on this as I'm not 100% where the duplicate call comes from in the current code

HLeithner - comment - 2 Dec 2020

In j4 we don't have the buildRawRoute() anymore so the check can be removed.

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#18353] - Call router->preprocesss only once per link when sef is off

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

Add a Comment