PR-staging

Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
16 Oct 2017

Pull Request for Issue #18289

Summary of Changes

Do not call MenuRules::preprocess twice per query link if SEO settings Search Engine Friendly URLs is off.

Testing Instructions

See issue #18289

After line 63 add debug to see difference after patch:

static $i=0;$i++;$this->router->app->enqueueMessage("$i: " . print_r($query, 1));

Expected result

Method is called only once per query link.

Actual result

Method is called twice.

Documentation Changes Required

No

avatar joomla-cms-bot joomla-cms-bot - change - 16 Oct 2017
Category Libraries
avatar csthomas csthomas - open - 16 Oct 2017
avatar csthomas csthomas - change - 16 Oct 2017
Status New Pending
avatar csthomas csthomas - change - 16 Oct 2017
The description was changed
avatar csthomas csthomas - edited - 16 Oct 2017
avatar FPerisa FPerisa - test_item - 9 Jan 2018 - Tested successfully
avatar fancyFranci
fancyFranci - comment - 9 Jan 2018

I have tested this item successfully on 3d12c95

Before:

1: Array ( [option] => com_content [view] => category [id] => 64 [Itemid] => 411 [format] => feed [type] => rss )
2: Array ( [option] => com_content [view] => category [id] => 64 [Itemid] => 411 [format] => feed [type] => rss )
3: Array ( [option] => com_content [view] => category [id] => 64 [Itemid] => 411 [format] => feed [type] => atom )
4: Array ( [option] => com_content [view] => category [id] => 64 [Itemid] => 411 [format] => feed [type] => atom )
[...]

After:

1: Array ( [option] => com_content [view] => category [id] => 64 [Itemid] => 411 [format] => feed [type] => rss )
2: Array ( [option] => com_content [view] => category [id] => 64 [Itemid] => 411 [format] => feed [type] => atom )
[...]
```<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/18353">issues.joomla.org/tracker/joomla-cms/18353</a>.</sub>
avatar csthomas csthomas - close - 2 Sep 2018
avatar csthomas
csthomas - comment - 2 Sep 2018

Due to lack of interest, I close it.

avatar csthomas csthomas - close - 2 Sep 2018
avatar csthomas csthomas - change - 2 Sep 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-09-02 12:02:10
Closed_By csthomas
Labels Added: PR-staging
avatar joomdonation
joomdonation - comment - 2 Sep 2018

If you re-open it, I will test it on tomorrow.

avatar csthomas
csthomas - comment - 2 Sep 2018

OK, one more chance:)

avatar csthomas csthomas - change - 2 Sep 2018
Status Closed New
Closed_Date 2018-09-02 12:02:10
Closed_By csthomas
avatar csthomas csthomas - change - 2 Sep 2018
Status New Pending
avatar csthomas csthomas - reopen - 2 Sep 2018
avatar csthomas csthomas - reopen - 2 Sep 2018
avatar csthomas
csthomas - comment - 11 Sep 2018

Any news?

avatar joomdonation
joomdonation - comment - 13 Sep 2018

@csthomas Just so you know, I looked at the PR but could not understand why it's called twice and don't know if it's safe to remove one call yet, will try to spend time to look at it later (just leave the PR opens here, even if I don't understand, I will just test it as an end-user and report the test result back)

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Jul 2019

I will just test it as an end-user and report the test result back

@joomdonation any news?

Add a Comment

Login with GitHub to post a comment