?
avatar phooka
phooka
22 Sep 2017

Steps to reproduce the issue

Relative URLs in srcset images have // prefixed

Images in srcset are created like so:
srcset="//index.php?p=theme...
instead of
srcset="/index.php?p=theme...

Fix is to modify /plugins/system/sef/sef.php line 144
$data[] = preg_replace('#(?!/|' . $protocols . '|#|')([^\s]+)\s+(.)#', $base . '$1 $2', $url);
replace with
$data[] = preg_replace('#^(?!/|' . $protocols . '|#|')([^\s]+)\s+(.
)#', $base . '$1 $2', $url);

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar phooka phooka - open - 22 Sep 2017
avatar joomla-cms-bot joomla-cms-bot - labeled - 22 Sep 2017
avatar ggppdk
ggppdk - comment - 22 Sep 2017

Hi @phooka

if you search for 'srcset' you find several other issues

and also a merged PR with 3.8.1 milestone
#17978

avatar phooka phooka - change - 22 Sep 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-09-22 17:37:42
Closed_By phooka
avatar phooka phooka - close - 22 Sep 2017

Add a Comment

Login with GitHub to post a comment