User tests: Successful: Unsuccessful:
Pull Request for Issue #18024 .
stream_register
to the Joomla\CMS\Utility\BufferStreamHandler
class.FtpClient
to explicitely register the wrapper using that method.Use with any extension that uses the FtpClient class and is currently broken.
Works
White Screen of Death
The new API has to be document and once we remove the B/C workaround (in 4.0) this has to be documented as well
Category | ⇒ | Libraries |
Status | New | ⇒ | Pending |
Title |
|
@nealrduncan Please add WeServer to PHP Interface value in next comment.
@Bakual does Comment of @nealrduncan mean its an successfully Test which i can alter?
@franz-wohlkoenig Yes but I wont value of setting I mentioned in #18075 (comment). Please keep eye on it.
altered successfully Test of @nealrduncan
but we did have to make the tmp directory owned by the ftp user and the web server group.
I don't think that it's a successful test then! The PR should solve the problem without any additional chown and/or chmod.
@ReLater It depends on WeServer to PHP Interface value and this is reason for my request #18075 (comment)
@franz-wohlkoenig must have this valiue added in comment.
cc @Webdongle
didn't get what this means.
The "WebServer to PHP Interface" information is missing that you find under menu System > System Information > Tabulator "System Information".
@franz-wohlkoenig @ReLater is right
set back Test by @nealrduncan to not tested.
@wojsmol apache2handler
@nealrduncan Then this
but we did have to make the tmp directory owned by the ftp user and the web server group.
is expected by me.
but we did have to make the tmp directory owned by the ftp user and the web server group.
Then
Something is seriously wrong
Maybe, but not related to this PR then.
@Webdongle @Bakual this is related to php-fpm setup mater of 1 line in config file..
@Bakual
Yes
we did have to make the tmp directory owned by the ftp user and the web server group.
#18075 (comment)
Is related to this patch. If Joomla previously worked on a server but after apply the path the Ownership (of a folder) had to be changed to include group ... then the change made by the patch is forcing the server admin to use looser security. Or are you suggesting that the server was set incorrectly in the first place and that the patch just high-lighted an error in the server configuration ?
All this PR does is reinstating the registering of the buffer so the FtpClient class works again as before. Nothing in the code itself changes, the behavior is exactly the same as before.
So if there is a permission issue, it is a separate issue.
All this PR does is reinstating the registering of the buffer so the FtpClient class
Does it use the exact same code/syntax to do that or is there a difference ?
the behavior is exactly the same as before.
So if there is a permission issue, it is a separate issue.
If the behavoiur is the same then why did the Group Ownership need to be changed ?
So even though it worked for @nealrduncan before without /tmp being Owned by the Group ... he should have have had the Group as Owner anyway ? Or did the Ownership need to be changed because it was a patch and not part of the original install ?
@Webdongle As you know I have few yours of expiriens a let's name this sysadmin. The company I work for has several dedicated servers. If I see that files and folders do not have chown user:user and files are not writable with chmod 644 and folders at 755 then I treat this as a server configuration error.
@mbabker Please comment.
Please open a new issue for the ownership issue. It certainly hasn't to do with this PR.
@Bakual
Thanks for confirming that @nealrduncan comment was a result of the server not the patch
We also had to chmod 774 tmp. I just realized that when I patch another site. So...
site owned by user using ftp
chown user.webserver tmp
chmod 774 tmp
Not ideal, but it works.
Labels |
Added:
?
|
Changed the method to a static function and adjusted the calls to fit.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-27 13:29:33 |
Closed_By | ⇒ | mbabker |
The solution in #18075 worked for us, but we did have to make the tmp directory owned by the ftp user and the web server group.