? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
21 Sep 2017

Summary of Changes

I've moved the forked flying-focus repo into a new one and started utilising grunt.
This PR simply replaces the old package with the new one

avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2017
Category JavaScript Repository Administration Templates (admin) Front End Templates (site)
avatar C-Lodder C-Lodder - open - 21 Sep 2017
avatar C-Lodder C-Lodder - change - 21 Sep 2017
Status New Pending
avatar C-Lodder C-Lodder - change - 25 Sep 2017
Labels Added: ?
avatar C-Lodder
C-Lodder - comment - 25 Sep 2017

@wilsonge conflicts fixed. Please merge when possible

avatar dgt41
dgt41 - comment - 27 Sep 2017

@C-Lodder can we instead of this sugar-on-broken-system actually implement something meaningful: #15906

I mean by default bootstrap is really bad for accessibility on all their buttons, so one way or another we need to fix it, so why not use CSS4 a little bit earlier?

avatar C-Lodder
C-Lodder - comment - 27 Sep 2017

I don't really mind what gets used tbh

avatar C-Lodder C-Lodder - change - 24 Oct 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-10-24 08:46:28
Closed_By C-Lodder
avatar C-Lodder C-Lodder - close - 24 Oct 2017
avatar brianteeman
brianteeman - comment - 24 Oct 2017

flyingfocus was much more than just the outline

avatar dgt41
dgt41 - comment - 24 Oct 2017

@brianteeman what do you mean? Flying focus is a visual effect on top of the focus ring, what else was there?

avatar brianteeman
brianteeman - comment - 24 Oct 2017

it does the flying part - the transition - which is very useful to indicate where the focus has been moved to without having to search the screen for just the outline

avatar dgt41
dgt41 - comment - 24 Oct 2017

Ok, so it's just the visual effect, which might not be that inclusive after all (for those with good vision the effect is a nice hint, but I guess for some visually impaired people the animation might be really annoying or not even visible). Anyways I'm not against flying focus if we first implement the css4 focus-ring (with the provided polyfill ATM)

avatar brianteeman
brianteeman - comment - 24 Oct 2017

if it is good enough for webaim.org then it should be good enough for joomla ;)

avatar dgt41
dgt41 - comment - 24 Oct 2017

I guess webaim.org is not using Bootstrap (which totally messes the focus ring). So in fact my proposal for css4 focus ring is more a patch to this annoying approach of BS4's outline: 0; and you can still have the sugar (effect) on top of it, if that is needed

avatar brianteeman
brianteeman - comment - 17 Nov 2017

I dont know why this was closed. The fix is required

avatar C-Lodder
C-Lodder - comment - 18 Nov 2017

I closed this in favour of a better approach

Add a Comment

Login with GitHub to post a comment