? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
11 Aug 2017

WIP

This PR updates Bootstrap to beta-1 which was released this morning. There's still a lot of fixes to be made to cater for ther B/C breaks, so probably not much point in testing.

Do NOT merge!


To-Do

  • Fix grid issue (@ciar4n may need your eyes on this).
  • Mobile menu showing on desktop (Possible a responsive utility class update needed).
  • Fix toolbar "save" dropdown misalignment
  • Investigate font-size mismatch between alpha-6 and beta-1
  • Update tests
avatar joomla-cms-bot joomla-cms-bot - change - 11 Aug 2017
Category JavaScript Repository Administration Templates (admin) Libraries
avatar C-Lodder C-Lodder - open - 11 Aug 2017
avatar C-Lodder C-Lodder - change - 11 Aug 2017
Status New Pending
avatar C-Lodder C-Lodder - change - 11 Aug 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 11 Aug 2017
avatar C-Lodder C-Lodder - change - 11 Aug 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 15 Aug 2017
Category JavaScript Repository Administration Templates (admin) Libraries JavaScript Repository Administration com_banners com_categories com_checkin com_contact com_content com_fields com_finder com_menus com_modules com_newsfeeds com_plugins com_postinstall com_search com_tags com_templates com_users Modules
avatar joomla-cms-bot joomla-cms-bot - change - 15 Aug 2017
Category JavaScript Repository Administration com_banners com_categories com_checkin com_contact com_content com_fields com_finder com_menus com_modules com_newsfeeds com_plugins com_postinstall com_search com_tags com_templates com_users Modules JavaScript Repository Administration com_associations com_banners com_categories com_checkin com_contact com_content com_fields com_finder com_menus com_modules com_newsfeeds com_plugins com_postinstall com_search com_tags com_templates
avatar brianteeman
brianteeman - comment - 15 Aug 2017

Please ping when it is ready for testing

avatar C-Lodder
C-Lodder - comment - 15 Aug 2017

will do, thanks @brianteeman

avatar C-Lodder C-Lodder - change - 15 Aug 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 15 Aug 2017
avatar C-Lodder C-Lodder - change - 15 Aug 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 15 Aug 2017
avatar C-Lodder
C-Lodder - comment - 15 Aug 2017

@brianteeman - apart from the first 2 things on the "to-do" list mentioned in my initial comment, could you give this a once over to see if anything drastic is going wrong, that would be appreciated. FYI you will need to reinstall Joomla to get the background colour variants on the demo modules for Aurora.

avatar brianteeman
brianteeman - comment - 15 Aug 2017

My four hour train journey from an unnamed location in the middle of Wales is almost over so I will have to put this on the todo list for tomorrow am as I suspect I am about to fall asleep in the keyboard

avatar brianteeman
brianteeman - comment - 15 Aug 2017

Some of the fonts seem to be different sizes for example

screenshotr20-35-57

screenshotr20-36-18

avatar brianteeman
brianteeman - comment - 15 Aug 2017

and there is a difference here as well - maybe its padding - not sure only a quick check

screenshotr20-37-46

screenshotr20-38-11

avatar C-Lodder C-Lodder - change - 15 Aug 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 15 Aug 2017
avatar brianteeman
brianteeman - comment - 15 Aug 2017

And another font size difference

screenshotr20-39-56

screenshotr20-39-35

avatar C-Lodder C-Lodder - change - 15 Aug 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 15 Aug 2017
avatar C-Lodder C-Lodder - change - 16 Aug 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 16 Aug 2017
avatar C-Lodder C-Lodder - change - 16 Aug 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 16 Aug 2017
avatar C-Lodder C-Lodder - change - 16 Aug 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 16 Aug 2017
avatar C-Lodder C-Lodder - change - 16 Aug 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 16 Aug 2017
avatar C-Lodder C-Lodder - change - 16 Aug 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 16 Aug 2017
avatar C-Lodder C-Lodder - change - 16 Aug 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 16 Aug 2017
avatar C-Lodder C-Lodder - change - 16 Aug 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 16 Aug 2017
avatar C-Lodder C-Lodder - change - 16 Aug 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 16 Aug 2017
avatar brianteeman
brianteeman - comment - 16 Aug 2017

@C-Lodder login font size and alert font size are now ok thanks - toolbar still the same

avatar C-Lodder
C-Lodder - comment - 16 Aug 2017

@brianteeman fixed

avatar C-Lodder C-Lodder - change - 20 Aug 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 20 Aug 2017
avatar C-Lodder C-Lodder - change - 20 Aug 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 20 Aug 2017
avatar C-Lodder C-Lodder - change - 21 Aug 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 21 Aug 2017
avatar C-Lodder
C-Lodder - comment - 21 Aug 2017

@wilsonge - This is good to go now. If there are however any glitches I've missed, a new issue can be opened.

avatar brianteeman
brianteeman - comment - 23 Aug 2017

Can this be merged now please?

avatar wilsonge wilsonge - change - 23 Aug 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-23 09:30:30
Closed_By wilsonge
avatar wilsonge wilsonge - close - 23 Aug 2017
avatar wilsonge wilsonge - merge - 23 Aug 2017
avatar brianteeman
brianteeman - comment - 23 Aug 2017

Thanks all

Add a Comment

Login with GitHub to post a comment