Pending

User tests: Successful: Unsuccessful:

avatar asika32764
asika32764
11 Aug 2017

Summary of Changes

The Standard rule will remove view and layout if found menu item's layout name same as query.

For example: view=foo&layout=blog will generate route as /blog.html

But if we use default layout, mostly we will not add layout to URL, the StandardRule will generate a route like: /blog.html&view=foo

This PR try to remove view and layout if menu item and query both has no layout params.

Testing Instructions

Install Joomla will test sample data, in admin open Australian Parks article and add a link with URL: index.php?option=com_content&view=featured, then save it.

Go to frontend and you will see the SEF link is: .../index.php/using-joomla/extensions/templates/beez-2/home-page-beez-2?view=featured

Apply this PR should remove the ?view=featured

avatar joomla-cms-bot joomla-cms-bot - change - 11 Aug 2017
Category Libraries
avatar asika32764 asika32764 - open - 11 Aug 2017
avatar asika32764 asika32764 - change - 11 Aug 2017
Status New Pending
avatar asika32764 asika32764 - change - 11 Aug 2017
The description was changed
avatar asika32764 asika32764 - edited - 11 Aug 2017
avatar asika32764 asika32764 - change - 11 Aug 2017
The description was changed
avatar asika32764 asika32764 - edited - 11 Aug 2017
avatar bayareajenn bayareajenn - test_item - 12 Aug 2017 - Tested unsuccessfully
avatar bayareajenn
bayareajenn - comment - 12 Aug 2017

I have tested this item ? unsuccessfully on 53425f7

I could not duplicate the problem after following the steps. My link didn't have a ?view=featured in it to begin with. :(


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17497.

avatar bayareajenn
bayareajenn - comment - 12 Aug 2017

Actually, I lied. I am able to get the ?view=featured in the url, but the patch didn't remove it unless I'm missing a step.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17497.

avatar Quy
Quy - comment - 31 Jan 2018

@asika32764 Is this the same as #18429?

avatar asika32764
asika32764 - comment - 31 Jan 2018

I'm not sure, I need test.

avatar joomla-cms-bot joomla-cms-bot - close - 26 Feb 2018
avatar Quy Quy - change - 26 Feb 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-02-26 16:50:55
Closed_By Quy
avatar joomla-cms-bot
joomla-cms-bot - comment - 26 Feb 2018

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/17497

avatar Quy
Quy - comment - 26 Feb 2018

No longer reproducible because of #18429


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17497.

Add a Comment

Login with GitHub to post a comment