? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
7 Aug 2017

Summary of Changes

When the article modal form field is shown on the front end then the filter strings are not translated.
image

Testing Instructions

Expected result

All strings are translated.

Actual result

The filters are not translated.

avatar joomla-cms-bot joomla-cms-bot - change - 7 Aug 2017
Category Administration com_content
avatar laoneo laoneo - open - 7 Aug 2017
avatar laoneo laoneo - change - 7 Aug 2017
Status New Pending
avatar infograf768
infograf768 - comment - 7 Aug 2017

Can we test this with pure core?
I am not aware of a frontend modal showing sorting fields for articles (Select Article only displays Search Tools afaik);

If this is only for your extension, don't you think we may have unwanted overrides between the frontend and backend lang strings if they have the same constants but variations in the values + loading the entire ini for just a few strings?
Would not it be simpler to just add the missing sorting strings in frontend or, as it concerns only your extension, in the extension ini file?

avatar laoneo
laoneo - comment - 7 Aug 2017

Here is only com_content involved as it is the modal form field which get's loaded. I don't think there side effects for it in this particular modal view. But to be 100% save the strings should be moved added to the front end ini file.

avatar infograf768
infograf768 - comment - 7 Aug 2017

But to be 100% save the strings should be moved to the front end ini file.

I guess you meant added ?
I would prefer that solution imho if it is really useful for 3pd.

avatar laoneo
laoneo - comment - 7 Aug 2017

Can you point me into the direction how I can identify them as fast as possible, then I will change the pr accordingly.

avatar infograf768
infograf768 - comment - 7 Aug 2017

Very few are in com_content, most are in main ini file:

<option value="">JGLOBAL_SORT_BY</option>
			<option value="a.ordering ASC">JGRID_HEADING_ORDERING_ASC</option>
			<option value="a.ordering DESC">JGRID_HEADING_ORDERING_DESC</option>
			<option value="a.state ASC">JSTATUS_ASC</option>
			<option value="a.state DESC">JSTATUS_DESC</option>
			<option value="a.featured ASC">JFEATURED_ASC</option>
			<option value="a.featured DESC">JFEATURED_DESC</option>
			<option value="a.title ASC">JGLOBAL_TITLE_ASC</option>
			<option value="a.title DESC">JGLOBAL_TITLE_DESC</option>
			<option value="category_title ASC">JCATEGORY_ASC</option>
			<option value="category_title DESC">JCATEGORY_DESC</option>
			<option value="a.access ASC">JGRID_HEADING_ACCESS_ASC</option>
			<option value="a.access DESC">JGRID_HEADING_ACCESS_DESC</option>
			<option value="association ASC" requires="associations">JASSOCIATIONS_ASC</option>
			<option value="association DESC" requires="associations">JASSOCIATIONS_DESC</option>
			<option value="a.created_by ASC">JAUTHOR_ASC</option>
			<option value="a.created_by DESC">JAUTHOR_DESC</option>
			<option value="language ASC">JGRID_HEADING_LANGUAGE_ASC</option>
			<option value="language DESC">JGRID_HEADING_LANGUAGE_DESC</option>
			<option value="a.created ASC">JDATE_ASC</option>
			<option value="a.created DESC">JDATE_DESC</option>
			<option value="a.modified ASC">COM_CONTENT_MODIFIED_ASC</option>
			<option value="a.modified DESC">COM_CONTENT_MODIFIED_DESC</option>
			<option value="a.publish_up ASC">COM_CONTENT_PUBLISH_UP_ASC</option>
			<option value="a.publish_up DESC">COM_CONTENT_PUBLISH_UP_DESC</option>
			<option value="a.publish_down ASC">COM_CONTENT_PUBLISH_DOWN_ASC</option>
			<option value="a.publish_down DESC">COM_CONTENT_PUBLISH_DOWN_DESC</option>
			<option value="a.hits ASC">JGLOBAL_HITS_ASC</option>
			<option value="a.hits DESC">JGLOBAL_HITS_DESC</option>
			<option value="rating_count ASC" requires="vote">JGLOBAL_VOTES_ASC</option>
			<option value="rating_count DESC" requires="vote">JGLOBAL_VOTES_DESC</option>
			<option value="rating ASC" requires="vote">JGLOBAL_RATINGS_ASC</option>
			<option value="rating DESC" requires="vote">JGLOBAL_RATINGS_DESC</option>
			<option value="a.id ASC">JGRID_HEADING_ID_ASC</option>
			<option value="a.id DESC">JGRID_HEADING_ID_DESC</option>
avatar infograf768
infograf768 - comment - 7 Aug 2017

That was for backend filter.
In frontend aricles filters are

<option value="">JGLOBAL_SORT_BY</option>
			<option value="a.ordering ASC">JGRID_HEADING_ORDERING_ASC</option>
			<option value="a.ordering DESC">JGRID_HEADING_ORDERING_DESC</option>
			<option value="a.state ASC">JSTATUS_ASC</option>
			<option value="a.state DESC">JSTATUS_DESC</option>
			<option value="a.title ASC">JGLOBAL_TITLE_ASC</option>
			<option value="a.title DESC">JGLOBAL_TITLE_DESC</option>
			<option value="category_title ASC">JCATEGORY_ASC</option>
			<option value="category_title DESC">JCATEGORY_DESC</option>
			<option value="association ASC" requires="associations">JASSOCIATIONS_ASC</option>
			<option value="association DESC" requires="associations">JASSOCIATIONS_DESC</option>
			<option value="a.access ASC">JGRID_HEADING_ACCESS_ASC</option>
			<option value="a.access DESC">JGRID_HEADING_ACCESS_DESC</option>
			<option value="a.created_by ASC">JAUTHOR_ASC</option>
			<option value="a.created_by DESC">JAUTHOR_DESC</option>
			<option value="language ASC">JGRID_HEADING_LANGUAGE_ASC</option>
			<option value="language DESC">JGRID_HEADING_LANGUAGE_DESC</option>
			<option value="a.created ASC">JDATE_ASC</option>
			<option value="a.created DESC">JDATE_DESC</option>
			<option value="a.id ASC">JGRID_HEADING_ID_ASC</option>
			<option value="a.id DESC">JGRID_HEADING_ID_DESC</option>
			<option value="a.featured ASC">JFEATURED_ASC</option>
			<option value="a.featured DESC">JFEATURED_DESC</option>
			<option value="a.hits ASC">JGLOBAL_HITS_ASC</option>
			<option value="a.hits DESC">JGLOBAL_HITS_DESC</option>

As I have no idea which one you use in your extension, can't help further.

avatar brianteeman brianteeman - change - 7 Aug 2017
Labels Added: ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Nov 2017

@laoneo should the Status be "Needs Review"?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17433.

avatar infograf768
infograf768 - comment - 1 Nov 2017

As is, it can't be merged as I pointed above:

don't you think we may have unwanted overrides between the frontend and backend lang strings if they have the same constants but variations in the values + loading the entire ini for just a few strings?

avatar laoneo
laoneo - comment - 2 Nov 2017

I'm closing it because of lack of time at the moment.

avatar laoneo laoneo - change - 2 Nov 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-11-02 07:56:49
Closed_By laoneo
avatar laoneo laoneo - close - 2 Nov 2017

Add a Comment

Login with GitHub to post a comment