? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
7 Aug 2017

Pull Request for Issue #17389

Summary of Changes

Days incorrectly displayed in popup

Testing Instructions

Please test on clean staging : https://github.com/joomla/joomla-cms/archive/staging.zip
Patch proposed by @balvard
After patch we should get

screen shot 2017-08-07 at 09 05 10

@balvard @farhadst
You are the only ones to know what should be. 😄

avatar joomla-cms-bot joomla-cms-bot - change - 7 Aug 2017
Category JavaScript Language & Strings
avatar infograf768 infograf768 - open - 7 Aug 2017
avatar infograf768 infograf768 - change - 7 Aug 2017
Status New Pending
avatar balvard
balvard - comment - 7 Aug 2017

Salam
I checked staging file.
and I saw no change on it.
screen shot 2017-08-07 at 12 43 16
Patch Links file is right.javascript:
https://patch-diff.githubusercontent.com/raw/joomla/joomla-cms/pull/17432.patch.
I can't approve current staging file.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17432.

avatar dgt41
dgt41 - comment - 7 Aug 2017

@balvard your code is in this PR, not in staging. So you have to apply this PR to get the updated code

avatar balvard
balvard - comment - 7 Aug 2017

Good
I approved it.

avatar balvard
balvard - comment - 7 Aug 2017

Yes
Test OK with new javascript edition.
Thank you.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17432.

avatar franz-wohlkoenig franz-wohlkoenig - alter_testresult - 7 Aug 2017 - balvard: Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Aug 2017

@balvard i altered your Test as successfully at Issue Tracker.

avatar farhadst farhadst - test_item - 7 Aug 2017 - Tested successfully
avatar farhadst
farhadst - comment - 7 Aug 2017

I have tested this item ✅ successfully on d5c7f25
and patch ok
I approved it.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17432.

avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Aug 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Aug 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 8 Aug 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-08 13:11:31
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 8 Aug 2017
avatar mbabker mbabker - merge - 8 Aug 2017

Add a Comment

Login with GitHub to post a comment