? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
7 Aug 2017

Same fix that was done in #17424, but for the Sample Data module. So it doesn't get lost if we eventually drop the SQL files.

avatar joomla-cms-bot joomla-cms-bot - change - 7 Aug 2017
Category Front End Plugins
avatar Bakual Bakual - open - 7 Aug 2017
avatar Bakual Bakual - change - 7 Aug 2017
Status New Pending
avatar mbabker
mbabker - comment - 7 Aug 2017

That was only applied onto 4.0. FWIW valid PR, but can't be merged until George gets staging merged up.

avatar Bakual
Bakual - comment - 7 Aug 2017

Ah true

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Nov 2017

@Bakual is this PR valid?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17434.

avatar Bakual Bakual - change - 1 Nov 2017
Title
Converting fix done in #17424 to Sample Data module
[4.0] Converting fix done in #17424 to Sample Data module
avatar Bakual Bakual - edited - 1 Nov 2017
avatar Bakual
Bakual - comment - 1 Nov 2017

Nah, it is not since we removed the plugin in the meantime.
I made a direct commit to fix it in the plugin repo: joomla-extensions/testing-sample-data@8cf11ba

avatar Bakual Bakual - change - 1 Nov 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-11-01 10:57:01
Closed_By Bakual
Labels Added: ? ?
avatar Bakual Bakual - close - 1 Nov 2017

Add a Comment

Login with GitHub to post a comment