Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#17362] - [4.0] Core.js cleanup Pt1

? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
31 Jul 2017

Pull Request for Issue # .

Summary of Changes

  • The function Joomla.popupWindow() moved to toolbar.js where it belongs

  • The function window.writeDynaList() moved to system\fields\moduleorder.js where it belongs

  • The function window.changeDynaList() was removed completely as it had no real usage

  • The function window.radioGetCheckedValue() was removed completely as it had no real usage

  • All the code in core.js was just muted (to help the syncing with 3.x)

Testing Instructions

Go to Administrator-> articles and press the help button on the toolbar, you should see a new window (with no toolbar and an error message, if so then this PR works)

Expected result

Actual result

Documentation Changes Required

Deprecations need to be done in the 3.X branch

@mbabker @wilsonge any objections here?

avatar joomla-cms-bot joomla-cms-bot - change - 31 Jul 2017
Category ⇒ JavaScript
avatar dgt41 dgt41 - open - 31 Jul 2017
avatar dgt41 dgt41 - change - 31 Jul 2017
Status New ⇒ Pending
avatar dgt41 dgt41 - change - 31 Jul 2017
The description was changed
avatar dgt41 dgt41 - edited - 31 Jul 2017
avatar dgt41 dgt41 - change - 31 Jul 2017
The description was changed
avatar dgt41 dgt41 - edited - 31 Jul 2017
avatar zero-24
zero-24 - comment - 31 Jul 2017

The function window.writeDynaList() moved to system\fields\moduleorder.js where it belongs

hmm looks like this file is not changed in this PR?

avatar dgt41
dgt41 - comment - 31 Jul 2017

@zero-24 check that file, the function already exists there, I just hadn't cleared it from core.js

avatar zero-24
zero-24 - comment - 31 Jul 2017

hmm that is a completly different code + signature?
https://github.com/joomla/joomla-cms/blob/4.0-dev/media/system/js/fields/moduleorder.js#L30

avatar dgt41
dgt41 - comment - 31 Jul 2017

@zero-24 it is, because it's a local function, not a global like it was before ;)

Also check the commit: 3d976e4

avatar joomla-cms-bot joomla-cms-bot - edited - 31 Jul 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 31 Jul 2017
Title
…
Core.js cleanup Pt1
[4.0] Core.js cleanup Pt1
avatar dgt41 dgt41 - change - 31 Jul 2017
Labels Added: ?
avatar C-Lodder C-Lodder - test_item - 1 Aug 2017 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 1 Aug 2017

I have tested this item ✅ successfully on 8607648

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17362.

avatar wilsonge wilsonge - change - 12 Aug 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-08-12 19:50:55
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 12 Aug 2017
avatar wilsonge wilsonge - merge - 12 Aug 2017

Add a Comment

Login with GitHub to post a comment