? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
30 Jul 2017

Pull Request for Issue # .

Summary of Changes

In Joomla 3, when selecting the state of something via the dropdown (published, unpulishged, trashed), the colour of the dropdown changed depending on the option selected (red/green).

This re-add the JS, providing the same functionality

Testing Instructions

  • Go to Module Manager. Open an existing module or create a new one.
  • On the right hand side, switch the State and notice the colour change.
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jul 2017
Category JavaScript
avatar C-Lodder C-Lodder - open - 30 Jul 2017
avatar C-Lodder C-Lodder - change - 30 Jul 2017
Status New Pending
avatar brianteeman brianteeman - test_item - 30 Jul 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 30 Jul 2017

I have tested this item successfully on 7be0611


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17354.

avatar dgt41
dgt41 - comment - 30 Jul 2017

Not as a core function, please, this is view related (only available in lists), not part of the joomla API!

avatar dgt41
dgt41 - comment - 30 Jul 2017

Also the whole document.addEventListener needs to go to the toolbar.js again this is not system API

avatar C-Lodder
C-Lodder - comment - 30 Jul 2017

Will continue tomorrow

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 31 Jul 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 31 Jul 2017

I have tested this item successfully on 7be0611


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17354.

avatar joomla-cms-bot joomla-cms-bot - change - 31 Jul 2017
Category JavaScript Libraries JavaScript
avatar C-Lodder C-Lodder - change - 31 Jul 2017
Labels Added: ?
avatar C-Lodder
C-Lodder - comment - 31 Jul 2017

@dgt41 - JS moved out of core.js

avatar dgt41
dgt41 - comment - 31 Jul 2017

Thanks, fields is the right place, for this!

@wilsonge please merge

avatar brianteeman brianteeman - test_item - 31 Jul 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 31 Jul 2017

I have tested this item successfully on 0b6fc9d

still good


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17354.

avatar wilsonge wilsonge - change - 31 Jul 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-31 11:15:14
Closed_By wilsonge
avatar wilsonge wilsonge - close - 31 Jul 2017
avatar wilsonge wilsonge - merge - 31 Jul 2017

Add a Comment

Login with GitHub to post a comment