[#17355] - Admin modules: no need to sort by language when filtering is disabled
- Fixed in Code Base
- 31 Jul 2017
- Medium
- Build: staging
- # 17355
- Diff
- infograf768:adminmodules_sorting
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Completing multilang administrator modules new feature
Summary of Changes
Added a specific requires in list.php and use it in the filter_modulesadmin.xml filter file.
Testing Instructions
Patch an instance of staging.
In Modules Parameters, enable or not Language Filtering
When Language Filtering is off, the Sorting options will no more display Sorting by language.
joomla-cms-bot
- | Category | ⇒ | Administration com_modules Libraries |
| Status | New | ⇒ | Pending |
I have tested this item
Set Module-Options Language Filtering to Yes got: Notice: Undefined index: nativeName in /Applications/MAMP/htdocs/3/administrator/components/com_modules/controller.php on line 87
This happens also without applied PR, so should i open a new Issue?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17355.
@franz-wohlkoenig
With which language have you tested?
If the language does not not contain nativeName in its xml, then it explains the issue.
Will make a patch to check this to solve this eventual issue (although language packs SHOULD contain the nativeName metadata.
@infograf768 Do we have requires="multilanguage" for frontend modules too? And I think this should be for every list page not just Module Manager.
I guess this will have to be done in 4.0 where there is a patch taking off language fields and columns when multilanguage is off.
Then this should also go in the same timeline for consistency.
Then this should also go in the same timeline for consistency.
Not sure, as this is a special method dealing with adminlanguage and not contentlanguage and it is used only for back-end modules, including in 4.0
@infograf768 aktive Lang. en-GB, also installed zh-CN, de-AT and fa-IR.
So i will mark Test successfully as you make another PR solving Notice?
@franz-wohlkoenig
Please check the xx-XX.xml metadata for these 3 languages.
But anyway, will make patch to cope with this
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17355.
en-GB, fa-IR, zh_CN have <nativeName></nativeName>; de-AT have not.
Please fix the title, "not enabled" or "disabled"
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17355.
@franz-wohlkoenig
so, that's the reason... We have to let it know to the German TT.
In the mean while, will make a PR
| Title |
|
||||||
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-31 11:42:56 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
@izharaazmi @franz-wohlkoenig
Please test #17359
@infograf768 Do we have
requires="multilanguage"for frontend modules too? And I think this should be for every list page not just Module Manager.