[#17316] - Add missing 'Show Subcategories Text' param to Contacts
- Closed
- 11 Mar 2022
- Medium
- Build: staging
- # 17316
- Diff
- nvyush:patch-3
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
- Pending JTracker/HumanTestResults Human Test Results: 0 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
For Contacts component:
/administrator/components/com_contact/config.xml - add missing show_category_heading_title_text parameter.
/components/com_contact/views/categories/tmpl/default.xml - add missing show_category_heading_title_text parameter, code style.
/components/com_contact/views/category/tmpl/default.xml - add missing show_category_heading_title_text parameter, code style.
Testing Instructions
Use a fresh Joomla, apply the patch.
Create a tree of some contact categories.
Create contacts with default options and place they to some contact categories.
Create menu items of the types Contacts » List All Contact Categories and Contacts » List Contacts in a Category for the root contact category.
Check the contact categories in the frontend. All should be fine.
Play with the option 'Show Subcategories Text' in the Global Configuration » Contacts, in the Category tab of the menu items you created.
NB!: When testing the menu item of the type Contacts » List All Contact Categories, the menu item of the type Contacts » List Contacts in a Category must be unpublished.
Expected result
When the option 'Show Subcategories Text' is Off in backend, the label "Subcategories" must not be shown in frontend.
Actual result
The option 'Show Subcategories Text' is missing in backend, the label "Subcategories" is shown always in frontend.
Documentation Changes Required
joomla-cms-bot
- | Category | ⇒ | Administration com_contact Front End |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
@Heggi93 I rechecked, all work. When you test the menu item of the type 'Contacts >> List All Contact Categories' you need to open some subcategory of the root category and test that page. It is important that the menu item of the type 'Contacts » List Contacts in a Category' must be unpublished, otherwise in this case that menu item will be opened.
| Labels |
Removed:
J3 Issue
|
||
I have tested this item
I have tested this successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17316.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17316.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17316.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17316.
| Labels |
Added:
?
?
Removed: ? |
||
Since Joomla 3 is not accepting new features, we would like to ask you to rebase your PR to the 4.2 branch to be tested in Joomla 4. In the meantime we close it. When ready for testing please reopen the pr.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-11 18:55:48 |
| Closed_By | ⇒ | laoneo |
it is NOT a new feature it is fixing a bug!!!
When you add new parameters, then I doubt that it is fixing a bug. What is broken without the pr?
If you read the post you will see - I really wonder sometimes if people prefer to just click close instead of actually reading and trying to understand
@brianteeman does this pr the same as #32736?
That PR is for j4
I have tested this item? unsuccessfully on 5f42d0f
I create a tree of categories with a depth of 3 and added some contacts to the categories. For the type Contacts >> List Contacts in a Category the button worked fine. The button is shown in the administration view and the title 'Subcategories' in the front-end worked as described.
For the type Contacts >> List All Contact Categories the button is shown in backend but doesen't work. Also if I unpublish the Contacts >> List Contacts in a Category item the selection has no effect on the view. After the selection of the root category the title 'Subcategories' is always shown.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17316.