? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
28 Jul 2017

Looks like there were a few things missed from the monster xml cleanup earlier. This fixes the last few

@Quy hope this is ok first time

avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2017
Category Administration com_plugins Language & Strings Modules Front End Unit Tests
avatar brianteeman brianteeman - open - 28 Jul 2017
avatar brianteeman brianteeman - change - 28 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2017
Category Administration com_plugins Language & Strings Modules Front End Unit Tests Administration com_plugins Modules Front End Unit Tests
avatar brianteeman brianteeman - change - 28 Jul 2017
Labels Added: ? ? ?
5138a77 28 Jul 2017 avatar brianteeman oops
avatar Quy
Quy - comment - 28 Jul 2017

There are more like the ones mentioned. Do you want me to point out each one?

avatar brianteeman
brianteeman - comment - 28 Jul 2017

Shoot - I just concentrated on the layout and forgot all about the order. I will recheck it all now

avatar brianteeman brianteeman - change - 28 Jul 2017
Labels Removed: ?
avatar brianteeman
brianteeman - comment - 28 Jul 2017

@Quy should all be ok now

avatar Quy Quy - test_item - 28 Jul 2017 - Tested successfully
avatar Quy
Quy - comment - 28 Jul 2017

I have tested this item successfully on 444320e

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17315.

avatar brianteeman
brianteeman - comment - 28 Jul 2017

@rdeutz are the appveyor errors something to be concerned abut for this pr?

avatar rdeutz
rdeutz - comment - 28 Jul 2017

seems to me a false positive, have re-started the build

avatar brianteeman
brianteeman - comment - 16 Aug 2017

Can we have one more test please

avatar sanderpotjer sanderpotjer - test_item - 31 Aug 2017 - Tested successfully
avatar sanderpotjer
sanderpotjer - comment - 31 Aug 2017

I have tested this item successfully on 444320e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17315.

avatar brianteeman
brianteeman - comment - 31 Aug 2017

Thanks for testing

avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Sep 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Sep 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 1 Sep 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-09-01 12:13:39
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 1 Sep 2017
avatar mbabker mbabker - merge - 1 Sep 2017
avatar brianteeman
brianteeman - comment - 1 Sep 2017

thanks - glad to see the back of these xml files

Add a Comment

Login with GitHub to post a comment