? ? Pending

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
28 Jul 2017

Summary of Changes

This is pretty much the same as #15915 but only for field groups.

Com_categories has a nice little feature which allows the component developer to place a form file on /administrator/components/com_foo/models/forms/category.xml which get loaded when editing a category.

This pr introduces the same functionality for com_fields. If a file is found on the location /administrator/components/com_foo/models/forms/fieldgroup/item.xml then this file get loaded when the entity com_foo.bar is edited.

You have to name the fields params

<?xml version="1.0" encoding="utf-8"?>
<form>
    <fields name="params">
        <fieldset name="basic">
            <field
                    name="display"
                    type="text"
                    default=""
            />
        </fieldset>
    </fields>
</form>

Testing Instructions

Put the xml in a component with custom fields support into
/administrator/components/com_foo/models/forms/fieldgroup/item.xml

Item is the section, check https://docs.joomla.org/J3.x:Adding_custom_fields/Implement_into_your_component for details

Expected result

You should see a new tab Options in your fieldgroup edit form

optionen

Documentation Changes Required

Would be nice to have that feature documented.

avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2017
Category SQL Administration com_admin Postgresql MS SQL com_fields
avatar rdeutz rdeutz - open - 28 Jul 2017
avatar rdeutz rdeutz - change - 28 Jul 2017
Status New Pending
avatar mbabker
mbabker - comment - 28 Jul 2017

Needs the install SQL but seems fine to me. If this can get tested today and tomorrow don't see any reason not to merge.

avatar rdeutz
rdeutz - comment - 28 Jul 2017

grrr, adding the install sql, I was sure I have forgotten something but couldn't figure out what :-)

avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2017
Category SQL Administration com_admin Postgresql MS SQL com_fields SQL Administration com_admin Postgresql MS SQL com_fields Installation
avatar rdeutz rdeutz - change - 28 Jul 2017
Labels Added: ?
avatar nielsnuebel
nielsnuebel - comment - 28 Jul 2017

Looks good for me. Everything works

avatar laoneo
laoneo - comment - 28 Jul 2017

Should the update files not contain 3.8.0 as version number and end with a new line?

avatar rdeutz
rdeutz - comment - 28 Jul 2017

Ofc, they should :-)

-- 
Viele Grüße/ Best Regards 
Robert

Am 28. Juli 2017 um 21:51:02, Allon Moritz (notifications@github.com) schrieb:

Should the update files not contain 3.8.0 as version number and end with a new line?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar infograf768
infograf768 - comment - 29 Jul 2017

I tried this on com_content and can't show the new field.

avatar nielsnuebel
nielsnuebel - comment - 29 Jul 2017

@infograf768 change item.xml to article.xml .

avatar infograf768
infograf768 - comment - 29 Jul 2017

Got it and I do get a new Option tab when editing a fieldgroup. But what can be the use of other Options in the fieldgroup itself? Any example that makes sense?

avatar infograf768 infograf768 - test_item - 29 Jul 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 29 Jul 2017

I have tested this item successfully on 298ffab


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17317.

avatar infograf768 infograf768 - alter_testresult - 29 Jul 2017 - nielsnuebel: Tested successfully
avatar infograf768 infograf768 - change - 29 Jul 2017
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 29 Jul 2017

RTC as it works as intended.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17317.

avatar infograf768
infograf768 - comment - 29 Jul 2017

@mbabker
Ready to go.

avatar rdeutz
rdeutz - comment - 29 Jul 2017

Think about a component where you have different fieldgroups, any of them should work a little bit different. With having the ability to add fields to the formgroup you can save the information how they should behave. Then you have to pick up the information in your overwrite/component and act accordingly.

avatar mbabker mbabker - change - 29 Jul 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-29 14:46:31
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 29 Jul 2017
avatar mbabker mbabker - merge - 29 Jul 2017
avatar rdeutz
rdeutz - comment - 29 Jul 2017

Thanks all who have been worked on this :-)

Add a Comment

Login with GitHub to post a comment