? ? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
11 Jul 2017

Pull Request for Issue #17041 .

Summary of Changes

Change the variable setCustomDir to the correct tinyMCE.activeEditor.settings.setCustomDir

Testing Instructions

Create a new article
Upload and upload a picture (Note: dragdrop upload)
Drag and drop again to upload the same picture (same file name)

Expected result

alert with a message that file exists

Actual result

Javascript,: Error:Uncaught, ReferenceError:, setCustomDir, is, not, defined

Documentation Changes Required

None

avatar dgt41 dgt41 - open - 11 Jul 2017
avatar dgt41 dgt41 - change - 11 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2017
Category JavaScript External Library
avatar AlexRed
AlexRed - comment - 11 Jul 2017

Ok, no more Javascript Error, but in the message window there is an "undefined" folder name:
File already exists.: undefined/images/imagename.png

undefined

avatar dgt41 dgt41 - change - 11 Jul 2017
Labels Added: ?
avatar dgt41
dgt41 - comment - 11 Jul 2017

@AlexRed thanks, there was a copy paste mistake there, it should be ok now.

avatar AlexRed AlexRed - test_item - 11 Jul 2017 - Tested successfully
avatar AlexRed
AlexRed - comment - 11 Jul 2017

I have tested this item successfully on ba91b1f

Patch ok for me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17063.

avatar Quy Quy - test_item - 11 Jul 2017 - Tested successfully
avatar Quy
Quy - comment - 11 Jul 2017

I have tested this item successfully on ba91b1f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17063.

avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Jul 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Jul 2017

RTC after two successful tests.

avatar wilsonge wilsonge - close - 12 Jul 2017
avatar wilsonge wilsonge - merge - 12 Jul 2017
avatar wilsonge wilsonge - change - 12 Jul 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-12 08:51:50
Closed_By wilsonge
Labels Added: ?

Add a Comment

Login with GitHub to post a comment