? ? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
11 Jul 2017

Pull Request for Issue # .

Summary of Changes

Adds a background color to quickicons area. Color change to quickicons.

Testing Instructions

Open 'control panel'

Before

quickicons1

Actual result

quickicons2

Documentation Changes Required

avatar ciar4n ciar4n - open - 11 Jul 2017
avatar ciar4n ciar4n - change - 11 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2017
Category Administration com_cpanel Modules Templates (admin)
avatar ciar4n ciar4n - change - 11 Jul 2017
Labels Added: ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Jul 2017

bildschirmfoto 2017-07-11 um 11 08 55
Will make a new Install and looks if this works.

avatar C-Lodder
C-Lodder - comment - 11 Jul 2017

@franz-wohlkoenig One of my PR's that got merged yesterday adds this file to the template. Please ensure you have the latest Joomla code before applying the patch.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 11 Jul 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Jul 2017

I have tested this item successfully on 60fcabf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17062.

avatar C-Lodder C-Lodder - test_item - 11 Jul 2017 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 11 Jul 2017

I have tested this item successfully on 60fcabf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17062.

avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Jul 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Jul 2017

RTC after two successful tests.

avatar wilsonge
wilsonge - comment - 11 Jul 2017

Can we check this new contrast meets AA

avatar wilsonge
wilsonge - comment - 11 Jul 2017

My guess is the white text on light blue and the light blue on the dark blue would fail. But only looking at the screenshots on my mobile which isn't exactly a reliable checker :p

avatar ciar4n ciar4n - change - 11 Jul 2017
Labels Added: ?
avatar ciar4n
ciar4n - comment - 11 Jul 2017

Original it was only AA compliant with small text. I've made buttons darker to be compliant for both small and large text...

quickicons3

avatar wilsonge wilsonge - change - 11 Jul 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-11 18:46:01
Closed_By wilsonge
avatar wilsonge wilsonge - close - 11 Jul 2017
avatar wilsonge wilsonge - merge - 11 Jul 2017

Add a Comment

Login with GitHub to post a comment