? ?
avatar laoneo
laoneo
2 Jul 2017

As already pointed out in #16582, there is an inconsistency between the MVC classes in

  • libraries/src/Joomla/CMS/Contoller
  • libraries/src/Joomla/CMS/Model
  • libraries/src/Joomla/CMS/View

and the rest of the namespaced classes. For example we suffixed the fields with Field or the helpers with Helper but the MVC classes not. So I suggest we suffix them with Controller, Model and View. Then the class \Joomla\CMS\Model\Form will become \Joomla\CMS\Model\FormModel. Additionally I would move them to the Mvc folder and rename the folder to all uppercase MVC as pointed out in #15175.

As an additional change, the extension classes should also end with the corresponding suffix, so for example the Articles Model becomes ArticlesModel.

Pinging here @Bakual, @wilsonge, @mbabker and @brianteeman for opinions.

avatar laoneo laoneo - open - 2 Jul 2017
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jul 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 2 Jul 2017
avatar zero-24 zero-24 - change - 2 Jul 2017
Title
Restructure namespaced MVC classes
[RFC] Restructure namespaced MVC classes
avatar zero-24 zero-24 - edited - 2 Jul 2017
avatar zero-24 zero-24 - change - 2 Jul 2017
Labels Added: ?
avatar zero-24 zero-24 - labeled - 2 Jul 2017
avatar laoneo laoneo - change - 2 Jul 2017
The description was changed
avatar laoneo laoneo - edited - 2 Jul 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 2 Jul 2017
Category Code style Feature Request
avatar laoneo
laoneo - comment - 19 Aug 2017

Closing as we have a pr.

avatar laoneo laoneo - change - 19 Aug 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-08-19 07:27:05
Closed_By laoneo
avatar laoneo laoneo - close - 19 Aug 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Aug 2017

closed as having Pull Request #17614


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16941.

Add a Comment

Login with GitHub to post a comment