? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
2 Jul 2017

Namespaces the JRoute class. Additionally it deprecates it and moves the single _ function to the router class in a none static way.

avatar laoneo laoneo - open - 2 Jul 2017
avatar laoneo laoneo - change - 2 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jul 2017
Category Libraries
avatar laoneo laoneo - change - 2 Jul 2017
Title
Namespace JRoute class
Namespace JRoute class and deprecate it
avatar laoneo laoneo - edited - 2 Jul 2017
avatar mbabker
mbabker - comment - 2 Jul 2017

If you're really going to move it like this, find a better name than _.

avatar mbabker
mbabker - comment - 2 Jul 2017

Also, not merging this one until we have #16879 in place. That will probably require re-reviewing your deprecation.

avatar laoneo
laoneo - comment - 2 Jul 2017

Makes sense...honestly I was not sure how to name that function so I took the easy way. But I'm up for suggestions.

avatar laoneo laoneo - change - 3 Jul 2017
Labels Added: ?
avatar mbabker
mbabker - comment - 21 Jul 2018

Closing, as is this is heavily out of date and after #16879 it needs to be rethought how to handle such a deprecation if it's going to be proposed and accepted.

avatar mbabker mbabker - change - 21 Jul 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-07-21 02:00:53
Closed_By mbabker
Labels Added: ?
Removed: ?
avatar mbabker mbabker - close - 21 Jul 2018

Add a Comment

Login with GitHub to post a comment