Joomla! Issue Tracker | Joomla! CMS #16942 - [Router] RuleStandard Fallback to nomenu URL if segments not found

Closed
25 Jan 2018
Medium
Build: staging
# 16942
Diff
asika32764:patch-15

Failure

Success hound No violations found. Woof! Details
Failure continuous-integration/drone/pr the build failed Details
Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
Error continuous-integration/jenkins/pr-merge This commit cannot be built Details

User tests: Successful: Unsuccessful:

asika32764
2 Jul 2017

Summary of Changes

If a nestable view has a menu linked to some child items, then other items which not in children and havn't assigned to any menus will unable to create route.

Testing Instructions

Create a component (com_test) with new router rules and nesteable view, and add some items:

- Foo
    - Bar
        - Yoo
- Flower
    - Japan
        -Sakura

Assign a menu to Bar, go to Bar page, all routes linked to Japan and Sakura will not work, only link to Bar.

The route will be:

Bar: /bar
Yoo: /bar/3-yoo
Japan: /bar (Wrong URL)
Sakura: /bar (Wrong URL)

This PR fixed that if a view can not found parent menu, it will use an exists menu and add view alias after it.

Japan: /bar/5-japan
Sakura: /bar/5-japan/6-sakura

Actually, I think the real solution is fallback to /component/test/5-japan/6-sakura not after /bar, but I don't know how to do this. Router rules is too complex...

7433d39 2 Jul 2017

[Router] RuleStandard Fallback to nomenu URL if segments not found

asika32764 - open - 2 Jul 2017

asika32764 - change - 2 Jul 2017

Status

New

⇒

Pending