Feeling Lucky
?
[#16915] - [CS] Code Style fixes for administrator/components/com_finder/
- Fixed in Code Base
- 14 Aug 2017
- Medium
- Build: staging
- # 16915
- Diff
- photodude:PHPCS2-com_finder
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue code style in com_finder
Summary of Changes
- Multi-line function call not indented correctly;
- Line indented incorrectly
- Logical operator "or" not allowed; use "||" instead
- Logical operator "and" not allowed; use "&&" instead
- Please consider an empty line before the if statement;
Automatically fixed with Joomla code standards 2.0.0 PHPCS2-alpha2 fixers
None of the manual only fixes have been applied
Testing Instructions
Merge by code review
Expected result
code style has been applied as listed above, old code style on drone does not error.
Actual result
code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to impliment fixable codestyle
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-14 18:04:07 |
| Closed_By | ⇒ | zero-24 |
zero-24
- comment
- 14 Aug 2017
Merged Thanks
I have tested this item✅ successfully on 94359eb
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16915.