[#16914] - [CS] Code Style fixes for administrator/components/com_fields/
- Fixed in Code Base
- 14 Aug 2017
- Medium
- Build: staging
- # 16914
- Diff
- photodude:PHPCS2-com_contenthistory
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Pull Request for Issue code style fixes
Summary of Changes
- No blank line found after control structure
- Please consider an empty line before the if statement;
- Expected 1 space after "!="; 0 found
- Expected 1 space after FUNCTION keyword; 0 found
- No blank line found after control structure
- Closing parenthesis of a multi-line function call must be on a line by itself
- Object operator not indented correctly;
- Please consider an empty line before the foreach statement;
- Expected 0 spaces before opening parenthesis; 1 found
- Multi-line function call not indented correctly;
- Whitespace found at end of line
Automatically fixed with Joomla code standards 2.0.0 PHPCS2-alpha2 fixers
None of the manual only fixes have been applied
Testing Instructions
Merge by code review
Expected result
code style has been applied as listed above, old code style on drone does not error.
Actual result
code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to impliment fixable codestyle
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
@photodude can you fix the conflicts?
are you sure that you can remove the new lines? As they come from the custom fields commit.? https://github.com/photodude/joomla-cms/blame/staging/administrator/components/com_fields/models/fields/type.php#L76
@zero-24 I just looked at staging... those lines are not there. https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_fields/models/fields/type.php#L51-L83
ah Sorry @photodude i got confused because i have looked in your staging branch and not the joomla one ;)
I have also reboot travis so this should pass in a few minutes too.
Merging for now. But I think https://github.com/joomla/joomla-cms/pull/16914/files/61af4a0cc311194c31e613e3175c9768ad767b3c#diff-f7da601c0a51808627cf42d006fbe02a needs a bit of thought as although it is indeed compliant with the sniffer seems a bit odd. Maybe open it on the code style repo
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-14 00:45:31 |
| Closed_By | ⇒ | wilsonge |
Definitely an issue for the code style repo
I have tested this item✅ successfully on e20e96d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16914.