Feeling Lucky
?
[#16916] - [CS] Code Style fixes for administrator/components/com_installer/
- Fixed in Code Base
- 15 Aug 2017
- Medium
- Build: staging
- # 16916
- Diff
- photodude:PHPCS2-com_installer
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Pull Request for Issue code style fixes
Summary of Changes
- Multi-line function call not indented correctly;
- No blank line found after control structure
- Closing parenthesis of a multi-line function call must be on a line by itself
- Please consider an empty line before the foreach statement;
- Expected 1 space after "="; 2 found
- Expected 1 space after FUNCTION keyword; 0 found
- Expected 3 tabs before opening brace; 4 found
- Whitespace found at end of line
Automatically fixed with Joomla code standards 2.0.0 PHPCS2-alpha2 fixers
None of the manual only fixes have been applied
Testing Instructions
Merge by code review
Expected result
code style has been applied as listed above, old code style on drone does not error.
Actual result
code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to implement fixable code style
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-15 12:36:06 |
| Closed_By | ⇒ | wilsonge |
I have tested this item✅ successfully on 629aa0f
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16916.