[#16904] - Fix for "CLI scripts print 'Application Instantiation Error' when redis cache enabled"
- Closed
- 23 Oct 2017
- Medium
- Build: staging
- # 16904
- Diff
- csthomas:redis_no_app
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #16903
Summary of Changes
Fix for "CLI scripts print 'Application Instantiation Error' when redis cache enabled"
The error message comes from:
https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/factory.php#L122
https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Factory.php#L137
which means that application instance has not been created yet.
Because on redis handler I stop using JFactory::getApplication() then I had to change other related lines.
Because I can not use $app and I should not display error message to front end:
if ($app->isClient('administrator'))
{
JError::raiseWarning(500, 'Redis connection failed');
}I changed it to:
throw new JCacheExceptionConnecting('Could not connect to redis server');
Testing Instructions
Install joomla with cache Redis enabled.
Go to joomla folder and run php -f cli/update_cron.php
Before patch you get error message.
After patch there is no errors.
Expected result
Script works without errors.
Actual result
Get exception message: Application Instantiation Error
Documentation Changes Required
I do not know.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
For a while I have a wrong commit with more changes, I removed that. Now IMO there is no place to put DEPLOY_VERSION
Sorry looks like github fools me than a few minutes ago i saw a new method being added here now it is gone. Thanks for checking.
There was a new method, but I removed it because it was not part of this PR.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16904.
I had to fix a conflict and I moved file changes to new location of redis file.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-23 12:31:12 |
| Closed_By | ⇒ | csthomas |
Please move the since tag to 'DEPLOY_VERSION' ;)