[#16905] - [4.0] Try and fix appveyor tests by mocking server globals
- Fixed in Code Base
- 29 Jun 2017
- Medium
- Build: 4.0-dev
- # 16905
- Diff
- wilsonge:fix-appveyor
User tests: Successful: Unsuccessful:
PR for issue #16698
This PR hopefully fixes the unit tests which are failing because they try to get a URI instance (either directly in Joomla\Cms\View\HtmlView::__construct() or in the case of the form fields, where they are getting URLs when including javascript files.
In 4.0 we now have stricter validation on URLs which is why we haven't seen this issue until now. Although there is no real reason to not port this back to staging as it is presumably an issue there - just one we ignore.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests |
Partly? The 15 JViewLegacy tests are now passing but the two form fields arent. It's weird, I'll keep digging
| Labels |
Added:
?
?
|
||
Well I mean this now passes. If anyone wants to explain why REQUEST_URI works for JViewLegacy but SCRIPT_NAME is required for the form fields be my guest :/
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-29 10:37:14 |
| Closed_By | ⇒ | wilsonge |
Looks like we have still the same error. On appveyor :(