?
avatar csthomas
csthomas
28 Jun 2017

Steps to reproduce the issue

Install joomla with cache Redis enabled.

Go to joomla folder and run php -f cli/update_cron.php

I get result:

Error displaying the error page: Application Instantiation Error: Application Instantiation Error

Expected result

Script works without errors

Actual result

Get exception message.

System information (as much as possible)

PHP 7.0 and 7.1 - not revelant
Joomla 3.7.3-dev and olders
Redis as cache handler and System Cache ON

Additional comments

The error comes from https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/factory.php#L122

and it starts at https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/cache/storage/redis.php#L67

Can we break B/C by removing $app = JFactory::getApplication(); and replacing
JError::raiseWarning(500, 'Redis connection failed');
by throw new JCacheExceptionConnecting('Could not connect to redis server');
in redis handler?

If yes then I can write PR.

avatar csthomas csthomas - open - 28 Jun 2017
avatar joomla-cms-bot joomla-cms-bot - labeled - 28 Jun 2017
avatar csthomas csthomas - change - 28 Jun 2017
The description was changed
avatar csthomas csthomas - edited - 28 Jun 2017
avatar mbabker
mbabker - comment - 28 Jun 2017

It's been argued adding new Exceptions to a method is a B/C break. If it's already throwing Exceptions, we're fine. Otherwise, I honestly don't want to get into the politics of it all again.

avatar csthomas
csthomas - comment - 28 Jun 2017

I put my solution at #16904

avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Jun 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-06-29 04:29:05
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jun 2017
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 29 Jun 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Jun 2017

closed as having PR #16904


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16903.

avatar joomla-cms-bot
joomla-cms-bot - comment - 29 Jun 2017

Add a Comment

Login with GitHub to post a comment