[#16902] - Fix for B/C in filter input
- Fixed in Code Base
- 3 Jul 2017
- Medium
- Build: staging
- # 16902
- Diff
- csthomas:fixfilter5
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #16812
Summary of Changes
This is minimalist version of my previous PR #16875
- Fix B/C - preserve
>character - Fix notice:
Notice: A non well formed numeric value encountered in .../libraries/joomla/filter/input.php on line 1202 divHello "Joomla"
tested as:
$_REQUEST['test'] = '<div>Hello "Joomla"</div>';
echo JFactory::getApplication()->input->getString('test', '');
Testing Instructions
Add in your template index.php a php code like:
$_REQUEST['test'] = '<div>Hello "Joomla"</div>';
echo JFactory::getApplication()->input->getString('test', '');
and
$_REQUEST['test'] = 'Menu > Modules';
echo JFactory::getApplication()->input->getString('test', '');
Expected result
Input methods getString() or getHtml() does not remove alone >.
There is no PHP Notice mentioned above.
Actual result
Input methods getString() or getHtml() removes > and this is B/C break.
PHP Notice mentioned above exists.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Unit Tests |
some tests would be good
I tested this item successfully.
The > is preserved as in 3.7.2. It's still stripping the < char, but this can be left for 3.7.4 and deeper analysis. This PR at least preserve the current 3.7.2 behavior.
@joeforjoomla i altered your Test as successfully at Issue Tracker.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-03 07:30:38 |
| Closed_By | ⇒ | rdeutz |
Any update on this? Is this issue going to be merged and fixed before the release of 3.7.3?