Feeling Lucky
?
?
[#16674] - [Plugins/system/debug] Some improvements and cleanups in plugins/system/debug
- Fixed in Code Base
- 19 Jul 2017
- Medium
- Build: staging
- # 16674
- Diff
- frankmayer:plugins-system-debug
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
Some improvements and cleanups in plugins/system/debug
- Make use of $this->db instead of JFactory::getDbo();
- Added missing docblocks
- Type-safety
- replace unnecessary strlen() call with simple check
- CS
Testing Instructions
Code review
Quick test of debugger
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
andrepereiradasilva
- comment
- 23 Jun 2017
pleaase check drone code style issues
http://213.160.72.75/joomla/joomla-cms/5868
frankmayer
- comment
- 28 Jun 2017
I don't get why codesniffer still fails...
Quy
- comment
- 28 Jun 2017
I have tested this item
Code revoew
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16674.
andrepereiradasilva
- comment
- 28 Jun 2017
I have tested this item
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16674.
andrepereiradasilva
- comment
- 28 Jun 2017
I have tested this item
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16674.
Quy
- comment
- 28 Jun 2017
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16674.
frankmayer
- comment
- 13 Jul 2017
@franz-wohlkoenig can we RTC this? Thanks
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 13 Jul 2017
RTC after two successful tests.
Thanks for Hint, @frankmayer
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-19 12:07:20 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
To be sure please also implement the fallback like for $this->app :)